Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors errno handling in the C NIF layer to centralize errno-to-term translation and to avoid using strerror() strings for exception reasons.
Changes:
- Introduces
make_errno_atom/2to translateerrnovalues (including-errnoreturn codes) into Erlang atoms, with special-cases for existing custom atoms. - Updates NIF read/write paths to raise exceptions using the new errno atom mapping instead of
strerror(...). - Simplifies
make_errno_error/2by delegating tomake_errno_atom/2(but this changes the error-term shape for “unexpected errors”).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| c_src/nif_utils.c | Adds make_errno_atom/2 and refactors errno error construction logic |
| c_src/gpio_nif.h | Exposes make_errno_atom/2 in the NIF utilities header |
| c_src/gpio_nif.c | Uses make_errno_atom/2 for raised exception reasons in read/write NIFs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.