Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this pull request
There are several bugs or enhancement in the hook
getInput()
in next.js project for Chromium (SyntaxError: The string did not match the expected pattern for Safari)stdout line 1
->stdout line 2
-> ... ->stdout line n
->stderr
.Fixing the bug in 1.
public/react-py-sw.js
for the service-worker;windows.location.origin
(location.origin
forpython-worker.ts
) as the base url of the url inPythonProvider
.Enhancing the output
For example, the python script
should results in
but the code in the docs will leads because the stdout is still updateing the results.
Due to the rendering bug in Safari. By observation, updating output array in stdout stream will end faster than updating the stdout. We can wait until the stdout stream is ended which is
stdout === output.join('')
and add thestderr
at the end.TODO