Skip to content

Update Rust in CI to v1.87.0 as well as dtolnay/rust-toolchain GitHub Action pinned commit hash #18596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update Rust in CI to v1.87.0 as well as dtolnay/rust-toolchain GitHub Action pinned commit hash #18596

wants to merge 4 commits into from

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Jun 25, 2025 •
edited
Loading

This PR does a few things. Best reviewed commit-by-commit.

The dtolnay/rust-toolchain GitHub Action works by either using a specific branch of it (in which case you don't need to specify the toolchain argument), or just using the master branch with the toolchain argument set.

To me, it's much more readable to just always use master, and then set toolchain via an environment variable.

This PR also updates the versions of Rust we were using to CI to the latest available, as especially the nightly version was starting to get quite stale. This is to include the latest checks and performance improvements to the compiler.

Supercedes #18396.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@anoadragon453
Unify usage of dtolnay/rust-toolchain
3d02498 
Let's always use the `master` branch such that we can specify the
version through the `toolchain` parameter.
@anoadragon453
Unify master commit we use across workflows
13219b7 
`b3b07ba8b418998c39fb20f53e8b695cdcc8de1b1` is the latest commit.

The date was removed as it will quickly become out of sync with the
commit hash when dependabot updates this action again.
@anoadragon453
Update rust versions in CI
8362300 
Let's try out the latest releases.
@anoadragon453
newsfile
32e5112
@anoadragon453 anoadragon453 changed the title Unify usage of dtolnay/rust-toolchain Update Rust in CI to v1.87.0 as well as dtolnay/rust-toolchain GitHub Action pinned commit hash Jun 25, 2025
@anoadragon453 anoadragon453 mentioned this pull request Jun 25, 2025
Closed
@anoadragon453 anoadragon453 marked this pull request as ready for review June 25, 2025 16:10
@anoadragon453 anoadragon453 requested a review from a team as a code owner June 25, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anoadragon453