Skip to content

Support modules sending server notices #18570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: hughns/server-notice-worker
Choose a base branch
from

Conversation

hughns
Copy link
Member

@hughns hughns commented Jun 18, 2025

Adds send_server_notice() to the module API. Relies on #18569 to make this safe to do so from workers.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@hughns hughns force-pushed the hughns/server-notice-worker branch from c380a22 to a041001 Compare June 18, 2025 17:02
@hughns hughns force-pushed the hughns/server-notice-module-api branch from 36246a0 to 0606e32 Compare June 18, 2025 17:03
@hughns hughns changed the title Support workers sending server notices Support modules sending server notices Jun 23, 2025
@hughns hughns force-pushed the hughns/server-notice-worker branch from 900d978 to 7ba64b6 Compare June 23, 2025 13:49
@hughns hughns force-pushed the hughns/server-notice-module-api branch from 9e29e8a to 82fcdc5 Compare June 23, 2025 13:52
@hughns hughns marked this pull request as ready for review June 23, 2025 13:54
@hughns hughns requested a review from a team as a code owner June 23, 2025 13:54
@hughns hughns marked this pull request as draft June 25, 2025 16:43
@anoadragon453 anoadragon453 removed the request for review from a team June 25, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant