Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add report user API from MSC4260 #18120

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Add report user API from MSC4260 #18120

wants to merge 13 commits into from

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jan 30, 2025 •
edited
Loading

matrix-org/matrix-spec-proposals#4260

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@turt2live turt2live mentioned this pull request Jan 30, 2025
Open
@turt2live turt2live marked this pull request as ready for review January 30, 2025 23:19
@turt2live turt2live requested a review from a team as a code owner January 30, 2025 23:19
@turt2live
Copy link
Member Author

test failures appear unrelated

sandhose
sandhose requested changes Feb 19, 2025
View reviewed changes
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

synapse/storage/schema/main/delta/88/07_add_user_reports.sql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you merge back develop & move this to the latest schema directory?

synapse/rest/client/reporting.py
Comment on lines +159 to +167
# Cast the Iterable to a list so that we can `append` below.
PATTERNS = list(
client_patterns(
"/org.matrix.msc4260/users/(?P<target_user_id>[^/]*)/report$",
releases=[], # unstable only
unstable=True,
v1=False,
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like to be a copy-paste from the room report API, when it got stabilised: https://github.com/element-hq/synapse/pull/17374/files#diff-c9b74d46cac48932cc854ad791337faad187cbbdb6bd64682b1bcc7740bfc563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandhose sandhose sandhose requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @sandhose