Derive kid from key #4876
Open
Derive kid from key #4876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements deriving a key’s ID if no explicit
kidis provided. Contains unit tests and documentation.secrets.keys.[].kidcan now be omitted and in this case the kid is automatically derived. If the field is set, the behavior is the same as before.Edit: The derived kid is now the key’s RFC 7638 JWK Thumbprint.
The derived kid is based on a key’s fingerprint: it simply takes the first four bytes and hex-encodes them.For creating the fingerprinting function I took inspiration from how OpenSSH and AWS are doing their key fingerprinting. They take some canonical byte-representation and hash them, but differ in the used hashing function and whether the private key or corresponding public key is used. I ended up using sha256 hashing on the corresponding public key encoded as PSCK#8 DER.