HAProxy startupProbe and named ports #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyff of changes in rendered templates of CI manifestsexample-default-enabled-components-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsmatrix-authentication-service-keep-auth-in-synapse-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsmatrix-authentication-service-synapse-secrets-externally-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsmatrix-authentication-service-synapse-secrets-in-helm-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricspytest-matrix-authentication-service-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricspytest-matrix-rtc-synapse-wellknown-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricspytest-synapse-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricspytest-well-known-values.yaml (changed)@@ spec.template.spec.containers.haproxy @@
# apps/v1/Deployment/default/release-name-haproxy
! + one map entry added:
+ startupProbe:
+ httpGet:
+ path: /haproxy_test
+ port: haproxy-metrics
+ periodSeconds: 2
+ failureThreshold: 150
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsquick-setup-certificates-pg-external-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsquick-setup-certificates-pg-with-helm-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsquick-setup-external-cert-pg-external-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsquick-setup-external-cert-pg-with-helm-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsquick-setup-letsencrypt-pg-external-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsquick-setup-letsencrypt-pg-with-helm-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsquick-setup-wildcard-cert-pg-external-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricsquick-setup-wildcard-cert-pg-with-helm-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricssynapse-checkov-with-workers-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricssynapse-ingress-additional-paths-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricssynapse-minimal-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricssynapse-postgres-secrets-externally-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricssynapse-postgres-secrets-in-helm-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricssynapse-secrets-externally-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricssynapse-secrets-in-helm-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricssynapse-worker-example-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricswell-known-checkov-values.yaml (changed)@@ spec.template.spec.containers.haproxy @@
# apps/v1/Deployment/default/release-name-haproxy
! + one map entry added:
+ startupProbe:
+ httpGet:
+ path: /haproxy_test
+ port: haproxy-metrics
+ periodSeconds: 2
+ failureThreshold: 150
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricswell-known-element-web-values.yaml (changed)@@ spec.template.spec.containers.haproxy @@
# apps/v1/Deployment/default/release-name-haproxy
! + one map entry added:
+ startupProbe:
+ httpGet:
+ path: /haproxy_test
+ port: haproxy-metrics
+ periodSeconds: 2
+ failureThreshold: 150
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricswell-known-mas-values.yaml (changed)@@ spec.template.spec.containers.haproxy @@
# apps/v1/Deployment/default/release-name-haproxy
! + one map entry added:
+ startupProbe:
+ httpGet:
+ path: /haproxy_test
+ port: haproxy-metrics
+ periodSeconds: 2
+ failureThreshold: 150
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricswell-known-minimal-values.yaml (changed)@@ spec.template.spec.containers.haproxy @@
# apps/v1/Deployment/default/release-name-haproxy
! + one map entry added:
+ startupProbe:
+ httpGet:
+ path: /haproxy_test
+ port: haproxy-metrics
+ periodSeconds: 2
+ failureThreshold: 150
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricswell-known-synapse-mas-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metricswell-known-synapse-values.yaml (changed)@@ spec.template.spec.containers.haproxy.startupProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8406
+ synapse-ready
@@ spec.template.spec.containers.haproxy.livenessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics
@@ spec.template.spec.containers.haproxy.readinessProbe.httpGet.port @@
# apps/v1/Deployment/default/release-name-haproxy
! ± type change from int to string
- 8405
+ haproxy-metrics |
gaelgatelement
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always want a
startupProbefor HAProxy. We also always want to use named ports (so that changing the port number doesn't cause breakages in the probes.The
periodSecondsandfailureThresholdare going to be extreme with no Synapse but this is a problem after #430 that we push onto users.Doing as a separate PR to minimise
dyff& increase reviewability