Skip to content

Handle media previews and invite avatars through the account data #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented May 22, 2025

Implemented APIs that update our media preview visibility and invite avatars visibility settings through account data.

The local settings are now discarded and a migration is implemented to check wether server configurations exist or not. In the latter case we simply push our current local configuration on the server to perform the migration, so that the user will still keep their setting.

This PR alo updates compound, so that is now possible to have loaders in inline pickers and toggles.

fixes #3923

@Velin92 Velin92 added the pr-feature for a new feature label May 22, 2025
Copy link

github-actions bot commented May 22, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Services/Client/ClientProxyProtocol.swift#L87 - TODOs should be resolved (This is a temporary value, in ...) (todo)

Generated by 🚫 Danger Swift against b227ab5

@Velin92 Velin92 force-pushed the mauroromito/media_preview_config_account_data_impl branch from e2d639a to 304470a Compare May 22, 2025 17:30
Copy link

codecov bot commented May 22, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1013 1 1012 0
View the top 1 failed test(s) by shortest run time
RoomNotificationSettingsScreenViewModelTests::testSetCustomMode()
Stack Traces | 1.32s run time
XCTAssertEqual failed: ("Optional(ElementX.RoomNotificationModeProxy.mute)") is not equal to ("Optional(ElementX.RoomNotificationModeProxy.mentionsAndKeywordsOnly)") (UnitTests/Sources/RoomNotificationSettingsScreenViewModelTests.swift:231)
View the full list of 1 ❄️ flaky tests
DeferredFulfillmentTests::testObservableWithSynchronousUpdate()

Flake rate in main: 11.63% (Passed 38 times, Failed 5 times)

Stack Traces | 10s run time
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting stream". (.../Other/Extensions/XCTestCase.swift:76)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Velin92 Velin92 marked this pull request as ready for review May 23, 2025 12:49
@Velin92 Velin92 requested a review from a team as a code owner May 23, 2025 12:49
@Velin92 Velin92 requested review from stefanceriu and removed request for a team May 23, 2025 12:49
@Velin92 Velin92 marked this pull request as draft May 26, 2025 08:44
@Velin92 Velin92 force-pushed the mauroromito/media_preview_config_account_data_impl branch 2 times, most recently from 7fc56a6 to ac408f8 Compare May 27, 2025 16:01
@Velin92 Velin92 marked this pull request as ready for review May 27, 2025 16:02
@Velin92 Velin92 force-pushed the mauroromito/media_preview_config_account_data_impl branch 2 times, most recently from 7805e2b to e52e527 Compare May 27, 2025 16:35
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm 👍

@Velin92 Velin92 force-pushed the mauroromito/media_preview_config_account_data_impl branch from 89386bb to a0f890f Compare May 28, 2025 15:16
@Velin92 Velin92 enabled auto-merge (squash) May 28, 2025 16:13
Copy link

@Velin92 Velin92 disabled auto-merge May 28, 2025 17:51
@Velin92 Velin92 merged commit aef91b5 into develop May 28, 2025
7 checks passed
@Velin92 Velin92 deleted the mauroromito/media_preview_config_account_data_impl branch May 28, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Set hide timeline media and invite avatars flag through the homeserver
2 participants