-
Notifications
You must be signed in to change notification settings - Fork 151
Handle media previews and invite avatars through the account data #4142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle media previews and invite avatars through the account data #4142
Conversation
Generated by 🚫 Danger Swift against b227ab5 |
e2d639a
to
304470a
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
7fc56a6
to
ac408f8
Compare
7805e2b
to
e52e527
Compare
ElementX/Sources/Screens/Settings/AvancedOptionsScreen/AdvancedSettingsScreenViewModel.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, lgtm 👍
89386bb
to
a0f890f
Compare
|
Implemented APIs that update our media preview visibility and invite avatars visibility settings through account data.
The local settings are now discarded and a migration is implemented to check wether server configurations exist or not. In the latter case we simply push our current local configuration on the server to perform the migration, so that the user will still keep their setting.
This PR alo updates compound, so that is now possible to have loaders in inline pickers and toggles.
fixes #3923