-
Notifications
You must be signed in to change notification settings - Fork 152
Fix animation glitch on 'this is the beginning of...' virtual event #4130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger Swift against 743d3c0 |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
|
@@ -8,6 +8,6 @@ | |||
import Foundation | |||
|
|||
struct TimelineStartRoomTimelineItem: DecorationTimelineItemProtocol, Equatable { | |||
let id: TimelineItemIdentifier = .virtual(uniqueID: .init(UUID().uuidString)) | |||
let id: TimelineItemIdentifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing needed is to do TimelineItemIdentifier = .virtual(uniqueID: .init("TimelineStart"))
or just "Start"
and the rest should come by itself quite easily without any other change in any other file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change anything else than TimelineStartRoomTimelineItem
added a comment with the easiest and fastest solution
Use a stable id for TimelineStartRoomTimelineItem rather than creating a new UUID each time.
Fixes #4129
Pull Request Checklist
UI changes have been tested with: