Skip to content

Fix animation glitch on 'this is the beginning of...' virtual event #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented May 18, 2025

Use a stable id for TimelineStartRoomTimelineItem rather than creating a new UUID each time.

Fixes #4129

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@ara4n ara4n requested a review from a team as a code owner May 18, 2025 00:09
@ara4n ara4n added the pr-bugfix for bug fix label May 18, 2025
@ara4n ara4n requested review from Velin92 and removed request for a team May 18, 2025 00:09
Copy link

github-actions bot commented May 18, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 743d3c0

Copy link

codecov bot commented May 18, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
1013 1 1012 0
View the full list of 1 ❄️ flaky tests
HomeScreenViewModelTests::testDeclineInvite()

Flake rate in main: 21.28% (Passed 37 times, Failed 10 times)

Stack Traces | 0.758s run time
XCTAssertEqual failed: ("["someAwesomeRoomId1", "someAwesomeRoomId2"]") is not equal to ("["someAwesomeRoomId2"]") (UnitTests/Sources/HomeScreenViewModelTests.swift:327)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link

@@ -8,6 +8,6 @@
import Foundation

struct TimelineStartRoomTimelineItem: DecorationTimelineItemProtocol, Equatable {
let id: TimelineItemIdentifier = .virtual(uniqueID: .init(UUID().uuidString))
let id: TimelineItemIdentifier
Copy link
Member

@Velin92 Velin92 May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing needed is to do TimelineItemIdentifier = .virtual(uniqueID: .init("TimelineStart")) or just "Start" and the rest should come by itself quite easily without any other change in any other file.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change anything else than TimelineStartRoomTimelineItem added a comment with the easiest and fastest solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badly mangled timeline animations for the "This is the beginning of..." text in new rooms
2 participants