Skip to content

Make OIDC identity reset consistent with EX #29854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025

Conversation

andybalaam
Copy link
Member

@andybalaam andybalaam commented Apr 30, 2025

Fixes #29809

This updates the wording of the OIDC version of the identity reset dialog to match the designs.

Before:
image

After:
image

(This does not perfectly match the designs because the dialog is not the right height, and it is a separate dialog instead of being integrated into the existing dialog/setting tab. However, the language is as specified, which was the minimum bar described in #29809)

This PR depends on localazy updates to the following 3 keys:

auth.uia.mas_cross_signing_reset_cta
auth.uia.mas_cross_signing_reset_description
auth.uia.mas_cross_signing_reset_title

which are included in this PR, since the pure localazy side breaks the build: #29853

@andybalaam andybalaam changed the title Allow providing an empty title to InteractiveAuthDialog Make OIDC identity reset consistent with EX Apr 30, 2025
@andybalaam andybalaam force-pushed the andybalaam/oidc-identity-reset branch from 0633d3f to 911b6d4 Compare April 30, 2025 14:47
@andybalaam andybalaam marked this pull request as ready for review May 2, 2025 09:00
@andybalaam andybalaam requested a review from a team as a code owner May 2, 2025 09:00
@andybalaam andybalaam requested review from dbkr and florianduros May 2, 2025 09:00
@andybalaam andybalaam force-pushed the andybalaam/oidc-identity-reset branch from e92fb83 to e8e7c25 Compare May 2, 2025 09:00
@andybalaam andybalaam enabled auto-merge May 2, 2025 09:20
@andybalaam andybalaam added this pull request to the merge queue May 2, 2025
Merged via the queue into develop with commit 72429c1 May 2, 2025
33 checks passed
@andybalaam andybalaam deleted the andybalaam/oidc-identity-reset branch May 2, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EW: Make OIDC identity reset consistent with EX
2 participants