test e2e: use encryption tab instead of Security & Settings tab in crypto.spec.ts #29595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ab in crypto.spec.ts
florianduros
force-pushed
the
florianduros/crypto-e2e
branch
from
e1339a0 to
4be9874
Compare
richvdh
reviewed
Mar 28, 2025
playwright/e2e/crypto/crypto.spec.ts
Outdated
Comment on lines
121
to
127
| return await test.step("Fetch master key from server", async () => { | ||
| const k = await app.client.evaluate(async (cli) => { | ||
| const userId = cli.getUserId(); | ||
| const keys = await cli.downloadKeysForUsers([userId]); | ||
| return Object.values(keys.master_keys[userId].keys)[0]; | ||
| }); | ||
| console.log(`fetchMasterKey: ${k}`); | ||
| const k = await app.client.evaluate( | ||
| // @ts-ignore we can't use the CrossSigning enum here | ||
| async (cli) => await cli.getCrypto().getCrossSigningKeyId("master"), | ||
| ); | ||
| return k; | ||
| }); |
There was a problem hiding this comment.
This no longer fetches the master key from the server, which (a) means the description on the test step is wrong, but more to the point, (b) rather defeats the point of the test.
There was a problem hiding this comment.
Hmm, I have the issue that cli.downloadKeysForUsers still returns the old master key. Cf crypto lobby discussion, I wonder what we should do here.
There was a problem hiding this comment.
florianduros
force-pushed
the
florianduros/crypto-e2e
branch
from
e795515 to
ede61d5
Compare
richvdh
approved these changes
Apr 7, 2025
playwright/e2e/crypto/crypto.spec.ts
Outdated
| // Find the "reset cross signing" button, and click it | ||
| await app.settings.openUserSettings("Security & Privacy"); | ||
| await page.locator("div.mx_CrossSigningPanel_buttonRow").getByRole("button", { name: "Reset" }).click(); | ||
| // Find the Reset cryptographic identity button |
There was a problem hiding this comment.
Suggested change
| // Find the Reset cryptographic identity button | |
| // Find the "Reset cryptographic identity" button |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #26468
Require matrix-org/matrix-js-sdk#4772