-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
e2e test: use encryption tab in enableKeyBackup
instead of security & settings tab
#29234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a033cd
to
e1a7ade
Compare
e1a7ade
to
5a0bc2d
Compare
enableKeyBackup
instead of security & settings tabenableKeyBackup
instead of security & settings tab
5a0bc2d
to
9720b1e
Compare
richvdh
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* | ||
* Assumes that the current device has been cross-signed (which means that we skip a step where we set it up). | ||
* Assumes that the current device has been verified | ||
* | ||
* Returns the recovery key | ||
*/ | ||
export async function enableKeyBackup(app: ElementAppPage): Promise<string> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should probably be renamed enableRecovery
, but that doesn't have to happen right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task #26468
Key backup section will be removed in #29088. Use the encryption tab instead of the security & privacy tab