Skip to content

e2e test: use encryption tab in enableKeyBackup instead of security & settings tab #29234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Feb 10, 2025

Task #26468
Key backup section will be removed in #29088. Use the encryption tab instead of the security & privacy tab

@florianduros florianduros added the T-Task Tasks for the team like planning label Feb 10, 2025
@florianduros florianduros force-pushed the florianduros/enable-key-backup branch from 9a033cd to e1a7ade Compare March 26, 2025 13:19
@florianduros florianduros force-pushed the florianduros/enable-key-backup branch from e1a7ade to 5a0bc2d Compare March 26, 2025 13:58
@florianduros florianduros changed the title test(e2e crypto): use encryption tab in enableKeyBackup instead of security & settings tab e2e test: use encryption tab in enableKeyBackup instead of security & settings tab Mar 26, 2025
@florianduros florianduros marked this pull request as ready for review March 26, 2025 14:17
@florianduros florianduros requested a review from a team as a code owner March 26, 2025 14:17
@florianduros florianduros requested a review from richvdh March 26, 2025 14:17
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

*
* Assumes that the current device has been cross-signed (which means that we skip a step where we set it up).
* Assumes that the current device has been verified
*
* Returns the recovery key
*/
export async function enableKeyBackup(app: ElementAppPage): Promise<string> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably be renamed enableRecovery, but that doesn't have to happen right now

@florianduros florianduros enabled auto-merge March 27, 2025 11:23
@florianduros florianduros added this pull request to the merge queue Mar 27, 2025
Merged via the queue into develop with commit a5673f6 Mar 27, 2025
32 checks passed
@florianduros florianduros deleted the florianduros/enable-key-backup branch March 27, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants