Skip to content

EW: Make OIDC identity reset consistent with EX #29809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uhoreg opened this issue Apr 24, 2025 · 4 comments · Fixed by #29854
Closed

EW: Make OIDC identity reset consistent with EX #29809

uhoreg opened this issue Apr 24, 2025 · 4 comments · Fixed by #29854
Assignees
Labels
A-E2EE A-Login A-OIDC O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement Team: Crypto

Comments

@uhoreg
Copy link
Member

uhoreg commented Apr 24, 2025

Background

Historically EW had many different identity resets, some of which only reset the cross-signing keys and some of which also reset "everything" (meaning any server-side copies of any keys as well as the server side storage as such). The other difference was that in some variants, EW also automatically asked user to set up recovery (on EX this step was separated from the reset flow).

To simplify it for the end users, and make it consistent with EX behavior, only one type of reset will be kept - the one that resets "everything" and does not set up recovery as part of it.

#29227 (which this is split off from) covered reset for legacy accounts. This covers reset for OIDC (MAS) accounts.

Modernizing the screen that is used in case of OIDC (user is directed to MAS web app) is a stretch goal. The minimum is to make sure that the copy of the current modal follows the copy of new designs (current modal on the left, new designs on the right).

Image

@dosubot dosubot bot added A-OIDC O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 24, 2025
@uhoreg
Copy link
Member Author

uhoreg commented Apr 24, 2025

The dialog box is MasUnlockCrossSigningAuthEntry from components/views/auth/InteractiveAuthEntryComponents.tsx.

Note that the new design changes the flow. In the existing design, the user clicks on the "Go to your account" button, which opens the account provider in a new browser window. After they are done resetting, they click the "Retry" button. In the new design, it looks like the user clicks the "Continue" button, which will open the account provider in a new browser window, but when it's done resetting, the app is supposed to automagically continue on. @mxandreas is that correct?

@mxandreas
Copy link

but when it's done resetting, the app is supposed to automagically continue on. @mxandreas is that correct?

I assume there was a good reason why the Retry button was added (e.g. hard to make it work reliably automagically, or perhaps even not possible at all). If that is the case then we can keep the Retry button - I have asked @americanrefugee in Figma to add this button to the designs as well. But I now realized that just adding the Retry button alone may be confusing for the user - we should probably adjust the label of the Retry button as well as the subtitle copy.

@americanrefugee
Copy link

I've updated the wording in the Figma file. Lemme know if it's correct now.

@mxandreas
Copy link

Looks good, I have also updated the snapshot in the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE A-Login A-OIDC O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement Team: Crypto
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants