-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update GIPHY embed structure for better responsiveness #724
Conversation
Hi @VerteDinde! Thank you for your point out #446 (comment) and now i have created pr for the gif responsive issue, can you check it out 😊. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ifhammohamed, how did you determine the styles to change here? I think we should just grab the embed code directly from GIPHY with "Responsiveness: On" checked, which produces slightly different output than you have here.
@dsanders11 I've made the GIPHY responsive by with "Responsiveness: On" checked, Thank you the suggestion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a compelling reason to use {{ ... }}
? I'd prefer using the exact output from GIPHY.
@dsanders11 as a response, you can't use string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request includes a change to the
blog/dec-quiet-period-24.md
file to improve the responsiveness of an embedded Giphy iframe.Improvements to embedded content:
blog/dec-quiet-period-24.md
: Replaced the static iframe with a responsive div container and adjusted the iframe styles to ensure the embedded Giphy content scales appropriately on different screen sizes.Issue of this pr -
[#722]
responsive error -
updated responsive page for mobile device -
other media size for the responsive -