Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump semver from 7.5.4 to 7.6.0 #1673

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 6, 2024

Bumps semver from 7.5.4 to 7.6.0.

Release notes

Sourced from semver's releases.

v7.6.0

7.6.0 (2024-01-31)

Features

Chores

Changelog

Sourced from semver's changelog.

7.6.0 (2024-01-31)

Features

Chores

Commits
  • 377f709 chore: release 7.6.0 (#661)
  • a7ab13a feat: preserve pre-release and build parts of a version on coerce (#671)
  • 816c7b2 chore: postinstall for dependabot template-oss PR
  • 0bd24d9 chore: bump @​npmcli/template-oss from 4.21.1 to 4.21.3
  • e521932 chore: postinstall for dependabot template-oss PR
  • 8873991 chore: chore: chore: postinstall for dependabot template-oss PR
  • f317dc8 chore: bump @​npmcli/template-oss from 4.19.0 to 4.21.0
  • 7303db1 chore: add clean() test for build metadata (#658)
  • 6240d75 chore: add missing quotes in README.md (#656)
  • 14d263f chore: postinstall for dependabot template-oss PR
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [semver](https://github.com/npm/node-semver) from 7.5.4 to 7.6.0.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.5.4...v7.6.0)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner February 6, 2024 13:20
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (376d46c) 92.03% compared to head (53d3609) 91.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1673      +/-   ##
==========================================
- Coverage   92.03%   91.80%   -0.24%     
==========================================
  Files          16       16              
  Lines         854      854              
  Branches      167      167              
==========================================
- Hits          786      784       -2     
- Misses         51       52       +1     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://app.codecov.io/gh/electron/packager/pull/1673/indirect-changes

Not a blocker, but it is kind of weird for a semver/minor dependency bump to change our code coverage.

Approving, but leaving unmerged pending a 2nd reviewer's opinion

@ckerr
Copy link
Member

ckerr commented Feb 6, 2024

Oh I see, other PRs bumping other dependencies are showing the same results, e.g. https://app.codecov.io/gh/electron/packager/pull/1672/indirect-changes.

Looks to me like this is unrelated to semver per se, probably something's changed in CI or main and even an empty commit PR would trigger the same codecov warning.

@ckerr ckerr merged commit babd200 into main Feb 6, 2024
5 of 6 checks passed
@ckerr ckerr deleted the dependabot/npm_and_yarn/semver-7.6.0 branch February 6, 2024 19:22
Copy link

🎉 This PR is included in version 18.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant