Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update discord invite link #1666

Merged
merged 1 commit into from
Jan 25, 2024
Merged

chore: update discord invite link #1666

merged 1 commit into from
Jan 25, 2024

Conversation

erickzhao
Copy link
Member

:)

@erickzhao erickzhao requested a review from a team as a code owner January 25, 2024 18:09
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the idea.

Asking since I just don't know this about Discord -- is that APGC3k5yaH link good for the long term?

Also, should this be updated elsewhere e.g. https://www.electronjs.org/community#boilerplates and https://github.com/electron/governance/blob/main/playbooks/responses/not-an-issue.md ?

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efaa437) 91.80% compared to head (daf7cfe) 91.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1666   +/-   ##
=======================================
  Coverage   91.80%   91.80%           
=======================================
  Files          16       16           
  Lines         854      854           
  Branches      167      167           
=======================================
  Hits          784      784           
  Misses         52       52           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@dsanders11
Copy link
Member

Merging as the test failure is obviously unrelated.

@dsanders11 dsanders11 merged commit 376d46c into main Jan 25, 2024
5 of 6 checks passed
@dsanders11 dsanders11 deleted the erickzhao-patch-1 branch January 25, 2024 22:18
@erickzhao
Copy link
Member Author

Asking since I just don't know this about Discord -- is that APGC3k5yaH link good for the long term?

We actually had the vanity /electronjs invite before but we made this one without an expiry date specifically to help track which invites come from GitHub and website links.

Copy link

🎉 This PR is included in version 18.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants