-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update discord invite link #1666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 on the idea.
Asking since I just don't know this about Discord -- is that APGC3k5yaH link good for the long term?
Also, should this be updated elsewhere e.g. https://www.electronjs.org/community#boilerplates and https://github.com/electron/governance/blob/main/playbooks/responses/not-an-issue.md ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1666 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 16 16
Lines 854 854
Branches 167 167
=======================================
Hits 784 784
Misses 52 52
Partials 18 18 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks legit
Merging as the test failure is obviously unrelated. |
We actually had the vanity |
🎉 This PR is included in version 18.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
:)