-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add possibility to ignore unsupported fuses #11
base: main
Are you sure you want to change the base?
feat: add possibility to ignore unsupported fuses #11
Conversation
@MarshallOfSound , could you please review this PR? |
@MarshallOfSound , @codebytere , could you please review this change? |
9a81235
to
65e18db
Compare
Oh, I did not expect that asking to re-review @codebytere will remove request for review of @MarshallOfSound . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of having an option that just disables a valid error message. I think this should be solved on the user side by consuming getCurrentFuseWire
and only flipping fuses conditionally that are in that wire.
Bloating the API surface of @electron/fuses
doesn't feel right IMO
@MarshallOfSound , thanks for the review. I noted in the initial issue that current logic where fuses are set takes into consideration unsupported fuses already and just does not set those. In case of flipping no longer supported fuses it just warns in the console instead of throwing an exception. From my point of view, this is inconsistency in terms of handling not supported fuses. I'd suggest to replace throwing of exception with Users will still have the possibility to break the build by themselves, comparing fuses they would like to set with those returned by What do you think about it? |
This PR introduces possibility to ignore not supported electron fuses specified in fuses config. Requirement for that behaviour is described in issue #10 .
This PR also introduces small changes in tests that make possible to run those tests on supported platforms without failing.