feat: add keyboard shortcut (ctrl/cmd-k) to clear console

[knqu]

Fixes #1557

Add CTRL/CMD+k keyboard shortcut to clear the console.

[knqu]

Having some trouble figuring out what's going wrong with these tests. This is my first time trying to contribute to an open source project, so I'd greatly appreciate any guidance from those more experienced with this project. The changes I made appear to work when I try to run Fiddle (ctrl+k) does indeed clear the console, but I'm failing a CI test with the following error: TypeError: Cannot read properties of undefined (reading 'CtrlCmd'). I spent considerable time trying to debug this, but couldn't find any inconsistencies between my code and the documentation for the Monaco Editor. Any advice would be much appreciated!

[BlackHole1]

Hi @knqu. The error in the unit tests is because we are using a Mock monaco solution in the tests, so when you use the Monaco API in the existing code, you need to add the same API in the Mock data.

See:

diff --git a/tests/mocks/monaco.ts b/tests/mocks/monaco.ts
index 0a5c9404..1cca8287 100644
--- a/tests/mocks/monaco.ts
+++ b/tests/mocks/monaco.ts
@@ -44,6 +44,12 @@ export class MonacoMock {
       },
     },
   };
+  public KeyMod = {
+    CtrlCmd: jest.fn(),
+  };
+  public KeyCode = {
+    KEY_K: jest.fn(),
+  };
 }
 
 export class MonacoEditorMock {
@@ -55,6 +61,7 @@ export class MonacoEditorMock {
   private model = new MonacoModelMock('', 'javascript');
   private scrollHeight = 0;
 
+  public addCommand = jest.fn();
   public dispose = jest.fn();
   public getAction = jest.fn(() => this.action);
   public getModel = jest.fn(() => this.model);

[knqu]

Thanks for the pointer @BlackHole1! I'll definitely keep that in mind going forward.

[codebytere]

@knqu could you please also add some logic to reset the console? From an abandoned PR:

https://github.com/electron/fiddle/pull/1669/files#diff-51ceea48515cf88b9698ed88bb3b808d1bdfe268fca34ba71bdf740e0f6cbb81R100-R106

once that's done we can merge this.

[knqu]

Hi @codebytere, thanks for getting back to me! That's a smart idea; I added it to my code. From my testing, the scroll logic seemed redundant, as clearing the console means there's nothing to scroll above, so I omitted that line. Please let me know if you have any other feedback!

[coveralls]

coverage: 87.472% (-0.03%) from 87.502%
when pulling ba4db50 on knqu:clear-console
into 39848ed on electron:main.