-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: support corepack packageManager and add related unit tests
#9309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d6254ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
corepack packageManager and add related unit tests [WIP]
…environments and using specific installation methods (+ snapshot verification) of package manager implementations
833e6b8 to
841a27f
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
bed4b3f to
cada898
Compare
corepack packageManager and add related unit tests [WIP]corepack packageManager and add related unit tests
|
After updating to 26.3.0, I started getting many warning logs during the build: https://github.com/any-listen/any-listen-desktop/actions/runs/19556675629/job/56000457263 These warning logs look like the following: These warnings appear in builds on Windows, macOS, and Linux. I noticed that these warnings did not exist in version 26.2.0. |
|
@lyswhut that's a new report. Can you please open a GH issue and follow the ISSUE_TEMPLATE.md to provide console logs with DEBUG=electron-builder env var set? |
yarnparser to no longer usenpm listand instead useyarn list. The JSON format is entirely different and doesn't possess the same tree setup thatnpm listreturns, but in this migration, we can officially supportcorepackfor yarn classic (asnpm listwon't run ifcorepack enablehas run).<package_name>.zip/<file_path>) We fallback to npm node module collection (since Yarn Berry could have npm-like structure OR pnpm-like structure, depending onnmHoistingLimitsconfiguration). In the latter case, we still can't assumepnpmis installed, so we still try to use npm collection as a best-effort attempt.All filesystem operations are async and memoized.
Migrated
packTesterto leveragecorepackfor isolating text/fixture environments and the various installation/hoisting setups they can have.Using specific installation methods in new unit tests (+ snapshot verification) of package manager implementations
Investigating fixes for: #9025 #9239 #9240 #8870 #9310