Skip to content

Conversation

@MichaelKatsoulis
Copy link
Contributor

Changes of this PR:

  • Parameter descriptions: Updated descriptions of parameters with information on when to increase the defaults
  • Default values: Emphasized its an outcome of extensive load testing
  • Deployment structure: Added dedicated "Deployment options" section on top
  • AWS CLI deployment: Added region guidance, moved template download, added stack update instructions
  • Console deployment: Added quick deployment link, manual steps, update instructions, reorganized SAR
  • Stack deletion: Split into CLI and Console options with separate instructions
  • Monitoring: Added new section with CloudWatch Metrics Explorer and Logs guidance
  • Kibana integration: Added CloudTrail Logs integration entry

@MichaelKatsoulis MichaelKatsoulis requested review from a team and theletterf as code owners November 6, 2025 16:01
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Copy link
Collaborator

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Made some edits directly to speed up things.

@elastic elastic deleted a comment from github-actions bot Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

Vale Linting Results

Summary: 22 suggestions found

💡 Suggestions (22)
File Line Rule Message
docs/reference/edot-cloud-forwarder/aws.md 101 Elastic.Passive In general, use active voice instead of passive voice ('be deployed').
docs/reference/edot-cloud-forwarder/aws.md 123 Elastic.Passive In general, use active voice instead of passive voice ('are hosted').
docs/reference/edot-cloud-forwarder/aws.md 123 Elastic.Passive In general, use active voice instead of passive voice ('be accessed').
docs/reference/edot-cloud-forwarder/aws.md 190 Elastic.Repetition "is" is repeated.
docs/reference/edot-cloud-forwarder/aws.md 194 Elastic.WordChoice Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'see', unless the term is in the UI.
docs/reference/edot-cloud-forwarder/aws.md 194 Elastic.Passive In general, use active voice instead of passive voice ('being dropped').
docs/reference/edot-cloud-forwarder/aws.md 196 Elastic.Passive In general, use active voice instead of passive voice ('been determined').
docs/reference/edot-cloud-forwarder/aws.md 208 Elastic.Acronyms 'ECF' has no definition.
docs/reference/edot-cloud-forwarder/aws.md 211 Elastic.FutureTense 'will be' might be in future tense. Write in the present tense to describe the state of the product as it is now.
docs/reference/edot-cloud-forwarder/aws.md 211 Elastic.Passive In general, use active voice instead of passive voice ('be deployed').
docs/reference/edot-cloud-forwarder/aws.md 211 Elastic.Passive In general, use active voice instead of passive voice ('are stored').
docs/reference/edot-cloud-forwarder/aws.md 428 Elastic.WordChoice Consider using 'open' instead of 'launch', unless the term is in the UI.
docs/reference/edot-cloud-forwarder/aws.md 430 Elastic.WordChoice Consider using 'open' instead of 'Launch', unless the term is in the UI.
docs/reference/edot-cloud-forwarder/aws.md 432 Elastic.Passive In general, use active voice instead of passive voice ('is required').
docs/reference/edot-cloud-forwarder/aws.md 538 Elastic.Passive In general, use active voice instead of passive voice ('are used').
docs/reference/edot-cloud-forwarder/aws.md 543 Elastic.Acronyms 'ALB' has no definition.
docs/reference/edot-cloud-forwarder/aws.md 543 Elastic.Acronyms 'NLB' has no definition.
docs/reference/edot-cloud-forwarder/aws.md 543 Elastic.Acronyms 'CLB' has no definition.
docs/reference/edot-cloud-forwarder/aws.md 545 Elastic.Passive In general, use active voice instead of passive voice ('are produced').
docs/reference/edot-cloud-forwarder/aws.md 547 Elastic.WordChoice Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI.
docs/reference/edot-cloud-forwarder/aws.md 548 Elastic.WordChoice Consider using 'refer to (if it's a document), view (if it's a UI element)' instead of 'See', unless the term is in the UI.
docs/reference/edot-cloud-forwarder/aws.md 641 Elastic.Passive In general, use active voice instead of passive voice ('be removed').

@MichaelKatsoulis
Copy link
Contributor Author

@theletterf could you suggest how to add these two information?

  1. explicitly call out we do not support the OTLP APM endpoint (MIS or Integration Server or APM Servers or APM Integrations)
  2. Add information on how to Get in touch with us

@theletterf theletterf merged commit fe1e904 into elastic:main Nov 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants