health-report: link to major.minor-versioned help docs on 9.0+ #17626
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
master
) instead of the docs that are specific to 9.0 (9.0
)What does this PR do?
master
${majorVersion}.x
${majorVersion}.${minorVersion}
Why is it important/What is the impact to the user?
When running Logstash 9.0, this makes the
help_url
-s in diagnostics correctly point to 9.0-specific guidance, instead of pointing to forward-facing guidance from the bleeding edge ofmain
/master
.As of the time of this writing, the two are the same; but as new things are added to
main
, they will eventually diverge.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksHow to test this PR locally
The procedure is the same in several configurations
Configurations:
git checkout -- versions.yml
./gradlew installDefaultGems --info | grep HelpUrl
https://www.elastic.co/guide/en/logstash/master/
yq -i '(.logstash, ."logstash-core") = "8.19.0"' versions.yml
./gradlew installDefaultGems --info | grep HelpUrl
https://www.elastic.co/guide/en/logstash/8.x/
yq -i '(.logstash, ."logstash-core") = "9.0.1"' versions.yml
./gradlew installDefaultGems --info | grep HelpUrl
https://www.elastic.co/guide/en/logstash/9.0/
yq -i '(.logstash, ."logstash-core") = "9.1.0"' versions.yml
RELEASE=1 ./gradlew installDefaultGems --info | grep HelpUrl
https://www.elastic.co/guide/en/logstash/9.1/
yq -i '(.logstash, ."logstash-core") = "8.19.0"' versions.yml
RELEASE=1 ./gradlew installDefaultGems --info | grep HelpUrl
https://www.elastic.co/guide/en/logstash/8.19/
yq -i '(.logstash, ."logstash-core") = "9.0.1"' versions.yml
RELEASE=1 ./gradlew installDefaultGems --info | grep HelpUrl
https://www.elastic.co/guide/en/logstash/9.0/