Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standalone agent access for agent-driven monitoring #17386

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

robbavey
Copy link
Member

@robbavey robbavey commented Mar 21, 2025

Change incorrect dedicated instructions, and base them on those from running Elastic Agent in standalone mode.

Closes: #16160

Copy link

mergify bot commented Mar 21, 2025

This pull request does not have a backport label. Could you fix it @robbavey? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • If no backport is necessary, please add the backport-skip label

Copy link
Contributor

📃 DOCS PREVIEWhttps://logstash_bk_17386.docs-preview.app.elstc.co/diff

1 similar comment
Copy link
Contributor

📃 DOCS PREVIEWhttps://logstash_bk_17386.docs-preview.app.elstc.co/diff

@robbavey robbavey marked this pull request as ready for review March 24, 2025 13:29
@robbavey robbavey added the backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches label Mar 26, 2025
@karenzone karenzone self-requested a review March 31, 2025 23:41
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestions inline for consideration

Comment on lines 55 to 58
`monitor` cluster privilege
`auto_configure` and `create_doc` index privileges on `logs-*` and `metrics-*` indices.
See [Grant standalone Elastic Agents access to Elasticsearch](docs-content://reference/fleet/grant-access-to-elasticsearch.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`monitor` cluster privilege
`auto_configure` and `create_doc` index privileges on `logs-*` and `metrics-*` indices.
See [Grant standalone Elastic Agents access to Elasticsearch](docs-content://reference/fleet/grant-access-to-elasticsearch.md)
- `monitor` cluster privilege
- `auto_configure` and `create_doc` index privileges on `logs-*` and `metrics-*` indices.
Check out [Grant standalone Elastic Agents access to Elasticsearch](docs-content://reference/fleet/grant-access-to-elasticsearch.md) for details.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this is rendering as you intended:

Screenshot 2025-03-31 at 7 46 07 PM

Copy link
Contributor

github-actions bot commented Apr 1, 2025

📃 DOCS PREVIEWhttps://logstash_bk_17386.docs-preview.app.elstc.co/diff

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files have been moved around and some redirects removed.
Please remove /ingestion-tools/ from all Agent doc paths. That's the source of the new failures.

(GitHub won't let me fix paths as a suggestion because this is not "changed content.") A rebase might fix?

robbavey and others added 5 commits April 1, 2025 13:07
Change incorrect dedicated instructions, and base them on those from running Elastic Agent
in standalone mode.
@robbavey robbavey force-pushed the fix_standalone_agent_monitoring branch from 42d0907 to efad6db Compare April 1, 2025 17:08
Copy link
Contributor

github-actions bot commented Apr 1, 2025

📃 DOCS PREVIEWhttps://logstash_bk_17386.docs-preview.app.elstc.co/diff

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robbavey robbavey merged commit 5a052b3 into elastic:main Apr 1, 2025
8 checks passed
mergify bot pushed a commit that referenced this pull request Apr 1, 2025
* Fix standalone agent access for agent-driven monitoring

Change incorrect dedicated instructions, and base them on those from running Elastic Agent
in standalone mode.

---------

Co-authored-by: Karen Metts <[email protected]>
(cherry picked from commit 5a052b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description of collecting metrics with standalone agent miss to add a role.
2 participants