Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(backport): remove former approach #17347

Merged
merged 1 commit into from
Mar 31, 2025
Merged

ci(backport): remove former approach #17347

merged 1 commit into from
Mar 31, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 18, 2025 •
edited
Loading

Release notes

[rn:skip]

What does this PR do?

Remove the former approach for backporting.

Why is it important/What is the impact to the user?

Mergify was enabled, see #16933

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Part of #16933

Use cases

Screenshots

Logs

@v1v v1v added backport-8.x Automated backport to the 8.x branch with mergify backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels Mar 18, 2025
@v1v v1v requested a review from pazone March 18, 2025 13:44
@v1v v1v self-assigned this Mar 18, 2025
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v
Copy link
Member Author

v1v commented Mar 26, 2025

@Mergifyio rebase

@mergify Mergify
Copy link

mergify bot commented Mar 26, 2025

rebase

✅ Branch has been successfully rebased

@v1v v1v force-pushed the feature/remove-former-backport-approach branch from 547b378 to 63d88ad Compare March 26, 2025 12:33
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 26, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @v1v

@v1v v1v requested review from robbavey and mashhurs March 28, 2025 07:28
robbavey
robbavey approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mashhurs
mashhurs approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@mashhurs mashhurs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

From my side, I have been facing any issues with Mergify so far.
For some special cases, I had called it and run with comments, working as expected.

And CI failures seem not related to this PR.

@mashhurs mashhurs mentioned this pull request Mar 28, 2025
Open
5 tasks
@v1v v1v merged commit 26af21d into elastic:main Mar 31, 2025
6 of 7 checks passed
mergify bot pushed a commit that referenced this pull request Mar 31, 2025
@v1v @mergify
ci(backport): remove former approach (#17347)
8552537 
(cherry picked from commit 26af21d)
@mergify mergify bot mentioned this pull request Mar 31, 2025
Merged
5 tasks
mergify bot pushed a commit that referenced this pull request Mar 31, 2025
@v1v @mergify
ci(backport): remove former approach (#17347)
5a12064 
(cherry picked from commit 26af21d)
@mergify mergify bot mentioned this pull request Mar 31, 2025
Merged
5 tasks
v1v added a commit that referenced this pull request Mar 31, 2025
@mergify @v1v
ci(backport): remove former approach (#17347) (#17456)
7bab842 
(cherry picked from commit 26af21d)

Co-authored-by: Victor Martinez <[email protected]>
v1v added a commit that referenced this pull request Mar 31, 2025
@mergify @v1v
ci(backport): remove former approach (#17347) (#17454)
a10dbed 
(cherry picked from commit 26af21d)

Co-authored-by: Victor Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

@mashhurs mashhurs mashhurs approved these changes

@pazone pazone Awaiting requested review from pazone

Assignees

@v1v v1v

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @elasticmachine @robbavey @mashhurs