-
Notifications
You must be signed in to change notification settings - Fork 513
[sentinel_one] Enhance ECS Mappings and Unify Field Structures across all Data Streams #15931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -140,10 +140,18 @@ processors: | |
| field: json.groupId | ||
| target_field: user.group.id | ||
| ignore_missing: true | ||
| - set: | ||
| field: group.id | ||
| copy_from: user.group.id | ||
| ignore_empty_value: true | ||
| - rename: | ||
| field: json.groupName | ||
| target_field: user.group.name | ||
| ignore_missing: true | ||
| - set: | ||
| field: group.name | ||
| copy_from: user.group.name | ||
| ignore_empty_value: true | ||
| - rename: | ||
| field: json.accountId | ||
| target_field: sentinel_one.activity.account.id | ||
|
|
@@ -156,6 +164,10 @@ processors: | |
| field: json.accountName | ||
| target_field: sentinel_one.activity.account.name | ||
| ignore_missing: true | ||
| - set: | ||
| field: sentinel_one.account.name | ||
| copy_from: sentinel_one.activity.account.name | ||
| ignore_empty_value: true | ||
| - rename: | ||
| field: json.agentId | ||
| target_field: sentinel_one.activity.agent.id | ||
|
|
@@ -193,14 +205,26 @@ processors: | |
| field: json.id | ||
| target_field: sentinel_one.activity.id | ||
| ignore_missing: true | ||
| - set: | ||
| field: event.id | ||
| copy_from: sentinel_one.activity.id | ||
| ignore_empty_value: true | ||
| - rename: | ||
| field: json.siteId | ||
| target_field: sentinel_one.activity.site.id | ||
| ignore_missing: true | ||
| - set: | ||
| field: sentinel_one.site.id | ||
| copy_from: sentinel_one.activity.site.id | ||
| ignore_empty_value: true | ||
| - rename: | ||
| field: json.siteName | ||
| target_field: sentinel_one.activity.site.name | ||
| ignore_missing: true | ||
| - set: | ||
| field: sentinel_one.site.name | ||
| copy_from: sentinel_one.activity.site.name | ||
| ignore_empty_value: true | ||
| - rename: | ||
| field: json.threatId | ||
| target_field: sentinel_one.activity.threat.id | ||
|
|
@@ -481,10 +505,18 @@ processors: | |
| field: json.data.threatClassification | ||
| target_field: sentinel_one.activity.data.threat.classification.name | ||
| ignore_missing: true | ||
| - set: | ||
| field: sentinel_one.threat_classification.name | ||
| copy_from: sentinel_one.activity.data.threat.classification.name | ||
| ignore_empty_value: true | ||
| - rename: | ||
| field: json.data.threatClassificationSource | ||
| target_field: sentinel_one.activity.data.threat.classification.source | ||
| ignore_missing: true | ||
| - set: | ||
| field: sentinel_one.threat_classification.source | ||
| copy_from: sentinel_one.activity.data.threat.classification.source | ||
| ignore_empty_value: true | ||
|
Comment on lines
512
to
+519
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't like that we are copying same value into 2 different fields with this change: It is mentioned here that this is worthy to be considered as a breaking-change, with updates to dashboards. @cpascale43 can you confirm if its still the case? If its going to be a breaking-change, then we should ideally remove the previous fields I checked the pre-built detection rules for
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, only a few fields are currently being copied into the I’ll wait for @cpascale43's suggestion on this. If we can treat it as a breaking change, we can proceed with removing the old fields and updating the dashboards if needed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @mohitjha-elastic @kcreddy I think since the prebuilt rules are not affected, we can remove the old fields and update the dashboards |
||
| - rename: | ||
| field: json.data.globalStatus | ||
| target_field: sentinel_one.activity.data.global.status | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| - name: sentinel_one | ||
| type: group | ||
| fields: | ||
| - name: account | ||
| type: group | ||
| fields: | ||
| - name: name | ||
| type: keyword | ||
| - name: site | ||
| type: group | ||
| fields: | ||
| - name: id | ||
| type: keyword | ||
| - name: name | ||
| type: keyword | ||
| - name: threat_classification | ||
| type: group | ||
| fields: | ||
| - name: name | ||
| type: keyword | ||
| - name: source | ||
| type: keyword |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| - name: sentinel_one | ||
| type: group | ||
| fields: | ||
| - name: account | ||
| type: group | ||
| fields: | ||
| - name: name | ||
| type: keyword | ||
| - name: site | ||
| type: group | ||
| fields: | ||
| - name: id | ||
| type: keyword | ||
| - name: name | ||
| type: keyword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this to changelog and commit message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added here to avoid CI failures since the related PR hadn’t been merged yet. As that PR has been merged today, this change will disappear once I sync the latest updates.