-
Notifications
You must be signed in to change notification settings - Fork 502
Remove Security Category Tag from Non-Security Packages #15611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove Security Category Tag from Non-Security Packages #15611
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
| # Added security category as Miniflux integration is assigned to security team | ||
| - security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clement-fouque Do you recall why this was added as a security integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we had a discussion but I don't remember why we added it. We can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is owned by security team, has it no security use case?
| - aws | ||
| - cloud | ||
| - observability | ||
| - security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mikaayenson What's your view on whether the bedrock integration is a security product?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have prebuilt security detection rules that leverage this integration.
This is the same case for azure_openai.
Note: We have some PRs in the work to further codify security related genai fields. See:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the changes for those!
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
feed_entry |
2020.2 | 1557.63 | -462.57 (-22.9%) | 💔 |
Package mongodb 👍(0) 💚(0) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
log |
26315.79 | 22222.22 | -4093.57 (-15.56%) | 💔 |
Package mysql 👍(1) 💚(0) 💔(2)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
error |
27027.03 | 15625 | -11402.03 (-42.19%) | 💔 |
slowlog |
21739.13 | 17543.86 | -4195.27 (-19.3%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Yes, we just do not yet have any prebuilt rules for this integration. And if we ever get a gemini integration that would too. |
|
@muthu-mps removed both! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm apart from 1 change
| # Added security category as Miniflux integration is assigned to security team | ||
| - security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is owned by security team, has it no security use case?
| # Added database_security category as it collects database logs and metrics including collection statistics, database statistics, and replication status | ||
| - database_security | ||
| # Added global security category as this integration collects security-relevant data | ||
| - security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
| # Added database_security category as it collects error logs, slow query logs, and replication status metrics that are relevant for database security monitoring | ||
| - database_security | ||
| # Added global security category as this integration collects security-relevant data | ||
| - security |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
|
CC @jamiehynds There was a whole re-categorization effort done recently to more effectively label the various use cases for each integration (see PR). As a result, additional solution categories were added to some integrations. The bigger picture: Next steps: |
|
@lalit-satapathy
|
|
If miniflux is not a security integration and it never was considered an observability integration then what type of integration is it? |
@norrietaylor or @jamiehynds any help with this integration? I have also checked telemetry and we had no trace of this integration to be used by customers for last year or so |
💚 Build Succeeded
History
cc @JDKurma |
I personally find the security (or observability) categories useful - they improve discoverability and help users quickly hone in on integrations relevant to their use case, or start broad and drill down (e.g., Security → Endpoint Security). They also allow our field teams to showcase our set of security or o11y quickly and easily. So far, there hasn’t been formal guidance or guardrails on which label should apply to which integrations. There are likely some gaps, but overall the current labels seem in reasonable shape. If certain integrations naturally span both domains (e.g., NetFlow), I don’t think dual categorization is a problem. |
I'm not overly familiar with the integration, but its owned by the security team and was developed by @clement-fouque who can probably clarify the intent behind it :) |
Proposed commit message
The following packages are categorized as
securitydespite not being semantically related tosecuritynor having security related datastreams:Datastreams:
[ { "package": "miniflux", "datastream": "miniflux.feed_entry" }, { "package": "mongodb", "datastream": "mongodb.collstats" }, { "package": "mongodb", "datastream": "mongodb.dbstats" }, { "package": "mongodb", "datastream": "mongodb.log" }, { "package": "mongodb", "datastream": "mongodb.metrics" }, { "package": "mongodb", "datastream": "mongodb.replstatus" }, { "package": "mongodb", "datastream": "mongodb.status" }, { "package": "mysql", "datastream": "mysql.error" }, { "package": "mysql", "datastream": "mysql.galera_status" }, { "package": "mysql", "datastream": "mysql.performance" }, { "package": "mysql", "datastream": "mysql.replica_status" }, { "package": "mysql", "datastream": "mysql.slowlog" }, { "package": "mysql", "datastream": "mysql.status" } ]I've removed the
securitytag for the above mentioned packages to accurately categorize them.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots