Enable MappingParserContext access to project metadata #138547
+70
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow project-specific mappings.
smalyshev
commented
Nov 24, 2025
smalyshev
added
>refactoring
:Search Foundations/Search
elasticsearchmachine
added
the
serverless-linked
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
romseygeek
requested changes
Nov 27, 2025
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
I think I'd want to include something that uses the new method as part of the same commit, if only to be sure that it is actually doing what we want it to do.
server/src/main/java/org/elasticsearch/index/mapper/DynamicFieldType.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/MapperService.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@romseygeek I am not sure how to add a usage to it, since the only real user of this interface in core does not need it. Do you have a suggestion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow project-specific mappings.