Use existing DocumentMapper when creating new MapperService
#138489
+43
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we create a new `MapperService` from an existing index for validation purposes, we often merge the mappings of the existing index into the temporary mapper service right after. This requires parsing the mappings and "merging" them (there's not much merging to do with an empty service, but we still need to traverse the mappings object). This can take up considerable time for larger mappings. By passing the existing `DocumentMapper` instance of the index (if available) to the new `MapperService`, the aforementioned mapping merge becomes a no-op and saves all that redundant processing.
nielsbauman
added
>enhancement
:Search Foundations/Mapping
Collaborator
|
Hi @nielsbauman, I've created a changelog YAML for you. |
Contributor
Author
|
These changes are related to #138367, but can be merged/viewed separately. I performed similar benchmarks for this PR as well. See #138367 (comment) for a brief explanation of what experiments I performed. Here is the same flamegraph on And here is the flamegraph on this PR: The rightmost merge/parse path completely disappeared, saving a lot of processing. |
elasticsearchmachine
added
the
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create a new
MapperServicefrom an existing index for validation purposes, we often merge the mappings of the existing index into the temporary mapper service right after. This requires parsing the mappings and "merging" them (there's not much merging to do with an empty service, but we still need to traverse the mappings object). This can take up considerable time for larger mappings.By passing the existing
DocumentMapperinstance of the index (if available) to the newMapperService, the aforementioned mapping merge becomes a no-op and saves all that redundant processing.