ESQL: Log profile on test error #131474
Merged
ESQL: Log profile on test error #131474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>test
nik9000
reviewed
Jul 17, 2025
...ugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/RestEsqlTestCase.java
Show resolved
Hide resolved
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ivancea
commented
Jul 18, 2025
| @@ -302,14 +304,6 @@ protected final void doTest(String query) throws Throwable { | |||
| } | |||
| } | |||
|
|
|||
| static Map<String, Object> assertNotPartial(Map<String, Object> answer) { | |||
There was a problem hiding this comment.
Moved this to the other class, with runEsql and assertWarnings
ivancea
commented
Jul 18, 2025
| } | ||
|
|
||
| public static Map<String, Object> runEsql(RequestObjectBuilder requestObject, AssertWarnings assertWarnings, Mode mode) | ||
| throws IOException { | ||
| return runEsql(requestObject, assertWarnings, mode, true); | ||
| } | ||
|
|
||
| public static Map<String, Object> runEsql(RequestObjectBuilder requestObject, AssertWarnings assertWarnings, |
There was a problem hiding this comment.
I kept here the overloads without the ProfileLogger param, as they will be easier to track, instead of looking for a null as a param
ivancea
force-pushed
the
show-profile-on-test-error
branch
from
548ad86 to
b284c41
Compare
# Conflicts: # x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/EsqlSpecIT.java
ivancea
added a commit
that referenced
this pull request
Jul 21, 2025
`SampleOperator.Status` wasn't declared as a NamedWritable by the plugin, leading to serialization errors when `SAMPLE` is used with `profile: true`. It leads to an `IllegalArgumentException: Unknown NamedWriteable [org.elasticsearch.compute.operator.Operator$Status][sample]` Profiles will be tested in this PR: #131474, that's currently failing because of this bug
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
Jul 21, 2025
`SampleOperator.Status` wasn't declared as a NamedWritable by the plugin, leading to serialization errors when `SAMPLE` is used with `profile: true`. It leads to an `IllegalArgumentException: Unknown NamedWriteable [org.elasticsearch.compute.operator.Operator$Status][sample]` Profiles will be tested in this PR: elastic#131474, that's currently failing because of this bug
nik9000
approved these changes
Jul 21, 2025
| // new RestEsqlTestCase.RequestObjectBuilder().query("FROM test* | LIMIT 2"), | ||
| // new AssertWarnings.NoWarnings(), | ||
| // profileLogger | ||
| // ); |
There was a problem hiding this comment.
Oh boy. I think maybe I should look at this one. I wrote this like two years ago.
|
💚 CLA has been signed |
ivancea
commented
Jul 22, 2025
| @@ -202,7 +202,7 @@ public static class Status implements Operator.Status { | |||
| public static final NamedWriteableRegistry.Entry ENTRY = new NamedWriteableRegistry.Entry( | |||
| Operator.Status.class, | |||
| "page_mapping_to_iterator", | |||
| AbstractPageMappingOperator.Status::new | |||
There was a problem hiding this comment.
This was another serialization error
# Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
ivancea
added a commit
that referenced
this pull request
Jul 28, 2025
Manual 9.1 partial backport, extracted from #131474
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
Jul 28, 2025
…#131820) Manual 9.1 partial backport, extracted from elastic#131474
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
Jul 28, 2025
…#131820) Manual 9.1 partial backport, extracted from elastic#131474
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
Jul 28, 2025
…#131820) Manual 9.1 partial backport, extracted from elastic#131474
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 28, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 28, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the ESQL request profile when a test fails.