Skip to content

Provide default entrypoint for the cloud-ess-fips image #127788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc commented May 6, 2025

In order to match the pattern for the other Cloud ESS image, provide a default entrypoint to the container that points to the configured docker entrypoint. This is described in

* The `ENTRYPOINT` is just `/sbin/tini`, and the `CMD` is
`/app/elasticsearch.sh`. In normal use this file would be bind-mounted
in, but the image ships a stub version of this file so that the image
can still be tested.
and implemented in
# Generate a stub command that will be overwritten at runtime
RUN mkdir /app && \\
echo -e '#!/bin/bash\\nexec /usr/local/bin/docker-entrypoint.sh eswrapper' > /app/elasticsearch.sh && \\
chmod 0555 /app/elasticsearch.sh

@donoghuc donoghuc requested a review from a team as a code owner May 6, 2025 21:32
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.1.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 6, 2025
@donoghuc
Copy link
Member Author

donoghuc commented May 6, 2025

Additional context: As a consumer of the cloud-ess-fips image, I want to use the default entrypoint without having to provide a custom app/elasticsearch.sh file or an override for the entrypoint. elastic/logstash#17627

@donoghuc donoghuc requested a review from breskeby May 6, 2025 21:36
@breskeby breskeby self-assigned this May 6, 2025
@breskeby breskeby added >non-issue :Delivery/Build Build or test infrastructure :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team v8.19.0 auto-backport Automatically create backport pull requests when merged labels May 6, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label May 6, 2025
@breskeby breskeby enabled auto-merge (squash) May 6, 2025 21:58
@breskeby breskeby merged commit 197d9b3 into elastic:main May 6, 2025
16 of 17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

parkertimmins pushed a commit to parkertimmins/elasticsearch that referenced this pull request May 7, 2025
donoghuc added a commit to donoghuc/elasticsearch that referenced this pull request May 7, 2025
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request May 9, 2025
afoucret pushed a commit to afoucret/elasticsearch that referenced this pull request May 9, 2025
jfreden pushed a commit to jfreden/elasticsearch that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Delivery Meta label for Delivery team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants