Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0] [Entitlements] Fix PolicyUtils and PolicyUtilsTests on Windows (#126185) #126236

Merged
merged 1 commit into from
Apr 3, 2025
Merged

[9.0] [Entitlements] Fix PolicyUtils and PolicyUtilsTests on Windows (#126185) #126236

merged 1 commit into from
Apr 3, 2025
+22 −9

Conversation

ldematte
Copy link
Contributor

@ldematte ldematte commented Apr 3, 2025

Backports the following commits to 9.0:

@ldematte
[Entitlements] Fix PolicyUtils and PolicyUtilsTests on Windows (elast…
8fafacd 
…ic#126185)

This PR fixes 2 issues discovered around PolicyUtils (and PolicyUtilsTests) when running CI on Windows:
- in tests, absolute paths like always are different, this fix updates the tests to account for the difference.
- on Windows, Files.move was failing because we were parsing the Entitlement policy but not closing the stream in a timely manner. This causes plugin installation (and related CI tests) to fail 70% of the time. Fixed by closing the stream properly

Fixes elastic#126176
@ldematte ldematte added :Core/Infra/Entitlements Entitlements infrastructure >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team test-windows Trigger CI checks on Windows labels Apr 3, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Apr 3, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 29cdb06 into elastic:9.0 Apr 3, 2025
21 checks passed
@ldematte ldematte deleted the backport/9.0/pr-126185 branch April 3, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests test-windows Trigger CI checks on Windows v9.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldematte @elasticsearchmachine