Work around testFilterByTags failure
#125109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A SDK bug[^1] means that these values sometimes don't parse as an integer. We don't need them to do so in order to pass the test, so this commit relaxes the test to accept any string. [^1]: aws/aws-sdk-java-v2#5968
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
added
the
auto-backport
|
There was another failure which I think is related. Do you mind unmuting this one also, assuming it fixes the problem too? #125166 |
|
Yep, tho that mute is in 8.x only right now, I will fix that up on the backport. |
DiannaHohensee
approved these changes
Mar 19, 2025
|
It does throw an exception, but |
DaveCTurner
added
the
auto-merge-without-approval
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
that referenced
this pull request
Mar 19, 2025
A SDK bug[^1] means that these values sometimes don't parse as an integer. We don't need them to do so in order to pass the test, so this commit relaxes the test to accept any string. Closes #125090 Closes #125166 [^1]: aws/aws-sdk-java-v2#5968
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Mar 21, 2025
A SDK bug[^1] means that these values sometimes don't parse as an integer. We don't need them to do so in order to pass the test, so this commit relaxes the test to accept any string. Closes elastic#125090 Closes elastic#125166 [^1]: aws/aws-sdk-java-v2#5968
omricohenn
pushed a commit
to omricohenn/elasticsearch
that referenced
this pull request
Mar 28, 2025
A SDK bug[^1] means that these values sometimes don't parse as an integer. We don't need them to do so in order to pass the test, so this commit relaxes the test to accept any string. Closes elastic#125090 Closes elastic#125166 [^1]: aws/aws-sdk-java-v2#5968
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Apr 14, 2025
This reverts commit 23769da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A SDK bug1 means that these values sometimes don't parse as an
integer. We don't need them to do so in order to pass the test, so this
commit relaxes the test to accept any string.
Closes #125090
Closes #125166
Footnotes
https://github.com/aws/aws-sdk-java-v2/issues/5968 ↩