Updates the method of ping from HEAD to OPTIONS #5138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
|
np for java |
|
It's also fine for Python. Actually Notice how this adds an error: we'll need to add it to https://github.com/elastic/elasticsearch/blob/main/rest-api-spec/src/main/resources/rest-api-spec/api/ping.json first. It's also fine to allow both |
picandocodigo
force-pushed
the
options_ping
branch
from
6dcf138 to
0a935d9
Compare
|
Thanks! |
picandocodigo
force-pushed
the
options_ping
branch
from
0a935d9 to
ef24275
Compare
picandocodigo
force-pushed
the
options_ping
branch
from
ef24275 to
7e1d4d9
Compare
|
Not moving forward with this after discussing with the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was proposed in elastic/elasticsearch#97613 (comment).
Opening this as a Draft to check with the rest of the Devtools team about this and see if it still makes sense and if all clients support the
OPTIONSmethod.Let me know, otherwise we can close this PR and the original issue.