Skip to content

Use Jackson as the default JSON implementations, update libraries #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 2, 2025

Conversation

swallez
Copy link
Member

@swallez swallez commented Mar 31, 2025

Our docs illustrate/promote using Jackson as a JsonMapper implementation, and yet it was an optional dependency.

This PR makes Jackson the default implementation, and makes it a required dependency. It also updates all JSON-related libraries to their latest version.

@l-trotta
Copy link
Contributor

l-trotta commented Apr 1, 2025

we're about to remove the serverless docs, we can merge #973 before this one

@swallez
Copy link
Member Author

swallez commented Apr 1, 2025

Yes, let's merge #973 and I'll rebase this PR.

@swallez swallez merged commit b93268f into main Apr 2, 2025
8 checks passed
@swallez swallez deleted the json-updates branch April 2, 2025 07:12
swallez added a commit that referenced this pull request Apr 2, 2025
@wilkinsona
Copy link

This change means that elasticsearch-rest-client is no longer on the consumer's classpath by default. Was that intentional? It's a breaking change in some situations and seems unrelated to using Jackson as the default JSON implementation.

@l-trotta
Copy link
Contributor

l-trotta commented Jun 26, 2025

Hey @wilkinsona, the elasticsearch-rest-client dependency change is explained more in depth in the release notes: https://www.elastic.co/docs/release-notes/elasticsearch/clients/java/9-0-0.

If you need additional info let me know! We tried making the release highlights as detailed as possible this time around, but maybe there are use cases we didn't consider.

@l-trotta
Copy link
Contributor

also beware of the known issues: https://www.elastic.co/docs/release-notes/elasticsearch/clients/java/known-issues#known-issues-9-0-0 and please use the latest patch 9.0.3 where said issue is fixed :)

@wilkinsona
Copy link

Thanks, @l-trotta. I only noticed the change upon a 9.0.2 to 9.0.3 upgrade. I guess that change must have shaken something else loose if the move to optional was in earlier 9.0.x releases. We've added a dependency on the old rest client for now and plan to switch to the new one.

@l-trotta
Copy link
Contributor

That is great to hear! Feel free to ping me if any help or additional explanation is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants