[Build] Support publishing maven artifacts directly to maven central #2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
changed the title
breskeby
changed the title
breskeby
commented
Jun 6, 2025
| project.tasks.withType(GenerateMavenPom).all { GenerateMavenPom pom -> | ||
| if (pom.name == "generatePomFileFor${publication.name.capitalize()}Publication") { | ||
| BasePluginExtension baseExtension = project.getExtensions().getByType(BasePluginExtension.class); | ||
| pom.destination = project.provider({"${project.buildDir}/distributions/${baseExtension.archivesName.get()}-${project.getVersion()}.pom"}) |
There was a problem hiding this comment.
this results in a deprecation warning and we would not want to rely on that workaround anymore.
breskeby
commented
Jun 6, 2025
|
|
||
| defaultTasks 'build' | ||
|
|
||
| dependencies { |
There was a problem hiding this comment.
we explicitly list the artifacts we want to publish here to avoid any accidental publication
breskeby
commented
Jun 6, 2025
| @@ -197,3 +198,15 @@ task generateDependenciesReport(type: ConcatFilesTask) { concatDepsTask -> | |||
| project.tasks.named('dependencyLicenses', DependencyLicensesTask) { | |||
| it.dependencies = project.configurations.licenseChecks | |||
| } | |||
|
|
|||
|
|
|||
| tasks.register('copyPoms', Copy) { | |||
There was a problem hiding this comment.
temporally we want to keep the build compatible with the existing DRA build. We can remove this workaround once we rely our releases on the new mechanism
breskeby
changed the title
breskeby
added a commit
to breskeby/elasticsearch-hadoop
that referenced
this pull request
Jun 11, 2025
…lastic#2397) * Adjusted nmcp compatibility with scala variants * Fixed dist maven publishing * Fix pom generation to ignore embedded dependencies * Minor cleanup * Build maven aggregation zip as part of dra build (cherry picked from commit 9d2dac9)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
breskeby
added a commit
to breskeby/elasticsearch-hadoop
that referenced
this pull request
Jun 11, 2025
…lastic#2397) * Adjusted nmcp compatibility with scala variants * Fixed dist maven publishing * Fix pom generation to ignore embedded dependencies * Minor cleanup * Build maven aggregation zip as part of dra build (cherry picked from commit 9d2dac9) # Conflicts: # .buildkite/dra.sh
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
breskeby
added a commit
to breskeby/elasticsearch-hadoop
that referenced
this pull request
Jun 11, 2025
…lastic#2397) * Adjusted nmcp compatibility with scala variants * Fixed dist maven publishing * Fix pom generation to ignore embedded dependencies * Minor cleanup * Build maven aggregation zip as part of dra build (cherry picked from commit 9d2dac9) # Conflicts: # .buildkite/dra.sh
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
breskeby
added a commit
to breskeby/elasticsearch-hadoop
that referenced
this pull request
Jun 11, 2025
…lastic#2397) * Adjusted nmcp compatibility with scala variants * Fixed dist maven publishing * Fix pom generation to ignore embedded dependencies * Minor cleanup * Build maven aggregation zip as part of dra build (cherry picked from commit 9d2dac9) # Conflicts: # .buildkite/dra.sh
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
breskeby
added a commit
that referenced
this pull request
Jun 11, 2025
…ntral (#2397) (#2400) * [Build] Support publishing maven artifacts directly to maven central (#2397) * Adjusted nmcp compatibility with scala variants * Fixed dist maven publishing * Fix pom generation to ignore embedded dependencies * Minor cleanup * Build maven aggregation zip as part of dra build (cherry picked from commit 9d2dac9) * Fix copyPoms default are different on non main branches it seems
breskeby
added a commit
that referenced
this pull request
Jun 11, 2025
…entral (#2397) (#2402) * [Build] Support publishing maven artifacts directly to maven central (#2397) * Adjusted nmcp compatibility with scala variants * Fixed dist maven publishing * Fix pom generation to ignore embedded dependencies * Minor cleanup * Build maven aggregation zip as part of dra build (cherry picked from commit 9d2dac9) # Conflicts: # .buildkite/dra.sh * Update spark artifacts for aggregation zip * Fix imports
breskeby
added a commit
that referenced
this pull request
Jun 11, 2025
…entral (#2397) (#2401) * [Build] Support publishing maven artifacts directly to maven central (#2397) * Adjusted nmcp compatibility with scala variants * Fixed dist maven publishing * Fix pom generation to ignore embedded dependencies * Minor cleanup * Build maven aggregation zip as part of dra build (cherry picked from commit 9d2dac9) # Conflicts: # .buildkite/dra.sh * Update spark artifacts for aggregation zip * Fix imports
breskeby
added a commit
that referenced
this pull request
Jun 11, 2025
…entral (#2397) (#2403) * [Build] Support publishing maven artifacts directly to maven central (#2397) * Adjusted nmcp compatibility with scala variants * Fixed dist maven publishing * Fix pom generation to ignore embedded dependencies * Minor cleanup * Build maven aggregation zip as part of dra build (cherry picked from commit 9d2dac9) # Conflicts: # .buildkite/dra.sh * Update spark artifacts for aggregation zip * Fix imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we create an maven central publishing compliant aggregation zip for all elasticsearch hadoop files we want to publish