Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Wildcard type #1579

Closed
wants to merge 1 commit into from
Closed

Conversation

algorri94
Copy link

@algorri94 algorri94 commented Apr 7, 2022

Solves #1488

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 7, 2022

❌ Author of the following commits did not sign a Contributor Agreement:
04a9e53

Please, read and sign the above mentioned agreement if you want to contribute to this project

@shaibrown5
Copy link

shaibrown5 commented May 8, 2022

@algorri94 any chance you can you can sign the agreement to merge?
if not I don't mind opening a new pr. please let me know

@algorri94
Copy link
Author

@algorri94 any chance you can you can sign the agreement to merge? if not I don't mind opening a new pr. please let me know

I already signed it, but it seems it's not triggering the build again

@pquentin
Copy link
Member

@algorri94 Sorry for the huge delay. You signed the CLA using your personal email, but the commit was made with your TrustYou email.

@miguelgrinberg
Copy link
Collaborator

Closing, since we cannot merge without a signed CLA.

@minaton-ru
Copy link

@miguelgrinberg
Hello! Please tell me is it ok if I make again such pull request with supporting for Wildcard type? It seems that there is no wildcard type field in Elasticsearch-dsl till now.

@miguelgrinberg
Copy link
Collaborator

@minaton-ru The Wildcard type is coming with release 8.18, currently planned for early April. Note that starting with 8.18 this library will be merged with the regular Python client, so the 8.18 code is in https://github.com/elastic/elasticsearch-py. You can take a look at the Wildcard field here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants