Skip to content

[9.0](backport #8148) otel: support system/metrics input with experimental otel runtime #8328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 4, 2025

What does this PR do?

This PR enables the system/metrics input to work with the otel runtime. It needs to be toggled explicitly by setting _runtime_experimental: otel in the input configuration.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues


This is an automatic backport of pull request #8148 done by [Mergify](https://mergify.com).

)

* otel: support system/metrics input with experimental otel runtime

* use EventuallyWithTf

* add tests comparing final documents

* trim test

* remove TestSystemMetricsInput

* remove unused vars

* ignore host.network.ingress fields

* fix typo in expectation message

* don't compare system metrics directly, only compare the keys are present

* ignore host.network.* fields

* remove dot from prefix

* ignore network activity fields

* ignore flaky fields from network

* stop ignoring elastic_agent.{snapshot,version}

* reestructure test to use a single config

* Revert "reestructure test to use a single config"

Windows throws errors about named pipes. I suspect system/metrics input
tries to register monitoring on the same socket.

This reverts commit aa6b4c6.

* remove agent.version from ignore list

* reorder stripNondeterminism call

* print documents in case of failure

* compare host-wide and normal network events separately

* simplify code

* Add Sudo to define.Require

* match for host metrics

* filter network interface events

* use tt.metricset, add note about network events

* add metricsets to template

* Update testing/integration/beat_receivers_test.go

Co-authored-by: Mikołaj Świątek <[email protected]>

* use AssertMapstrEqual

---------

Co-authored-by: Mikołaj Świątek <[email protected]>
(cherry picked from commit 5648918)
@mergify mergify bot added the backport label Jun 4, 2025
@mergify mergify bot requested a review from a team as a code owner June 4, 2025 11:41
@mergify mergify bot requested review from blakerouse and kaanyalti and removed request for a team June 4, 2025 11:41
@github-actions github-actions bot added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team skip-changelog labels Jun 4, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mauri870 mauri870 requested review from mauri870 and removed request for blakerouse and kaanyalti June 5, 2025 18:13
@mauri870 mauri870 enabled auto-merge (squash) June 5, 2025 20:59
Copy link

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 5, 2025

💔 Build Failed

Failed CI Steps

History

cc @mauri870

@mauri870
Copy link
Member

mauri870 commented Jun 6, 2025

Blocked on #8378 since it needs the Beats fix in elastic/beats#44456.

@swiatekm
Copy link
Contributor

swiatekm commented Jun 6, 2025

I thought we decided not to backport these changes to 9.0.

@mauri870
Copy link
Member

mauri870 commented Jun 6, 2025

I thought we decided not to backport these changes to 9.0.

Ah, I forgot about that—sorry. Closing.

@mauri870 mauri870 closed this Jun 6, 2025
auto-merge was automatically disabled June 6, 2025 12:52

Pull request was closed

@mergify mergify bot deleted the mergify/bp/9.0/pr-8148 branch June 6, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants