-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.16](backport #6730) Add conditions to copy_fields processor #7334
Conversation
This commit adds conditions to the `copy_fields` processor from the monitoring Filebeat to prevent it from failing and spamming the event logger at debug level with: `target field xxx already exists, drop or rename this field first` --------- Co-authored-by: Pierre HILBERT <[email protected]> (cherry picked from commit acf1098) # Conflicts: # testing/integration/logs_ingestion_test.go
Cherry-pick of acf1098 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏 |
💔 Build Failed
Failed CI StepsHistory
cc @belimawr |
What does this PR do?
This commit adds conditions to the
copy_fields
processor from the monitoring Filebeat to prevent it from failing and spamming the event logger at debug level with:target field xxx already exists, drop or rename this field first
Why is it important?
It makes the debug logs more useful by remove unnecessary entries from our monitoring Filebeat
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragments
using the changelog tool## Disruptive User ImpactHow to test this PR locally
Create a log file with more than 1kb:
docker run -it --rm mingrammer/flog -n 20 > /tmp/flog.log
Package the Elastic-Agent from this PR
Start the Elastic-Agent with the following configuration
elastic-agent.yml
Ensure the event logs (
data/elastic-agent*/logs/events/*.ndjson
) do not contain any messages from thecopy_fields
processor. The following command must return0
:Related issues
copy_fields
processor error #5299Questions to ask yourself
This is an automatic backport of pull request #6730 done by [Mergify](https://mergify.com).