Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/5595 force uninstall correct installation #6559

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kaanyalti
Copy link
Contributor

@kaanyalti kaanyalti commented Jan 21, 2025

  • Bug

What does this PR do?

Updates the uninstall command so that when the development agent is installed with --force flag and if there is already a development agent, then the command will replace the already existing development agent

Why is it important?

Currently force installing the development agent removes the production agent.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

How to test this PR locally

  • Install the agent with and without the --develop flag
  • Try to reinstall each agent with the --force flag
  • Validate that the force installation replaces the correct agent
    • Development replaces development
    • Production replaces production

Related issues

@kaanyalti kaanyalti force-pushed the fix/5595_force_uninstall_correct_installation branch from 7066058 to 4991423 Compare January 21, 2025 04:47
Copy link
Contributor

mergify bot commented Jan 21, 2025

This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 21, 2025

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 21, 2025
@kaanyalti kaanyalti marked this pull request as ready for review January 21, 2025 06:32
@kaanyalti kaanyalti requested a review from a team as a code owner January 21, 2025 06:32
@swiatekm swiatekm added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 21, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a changelog.

@kaanyalti kaanyalti requested a review from jlind23 January 21, 2025 16:18
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a question before approval.

internal/pkg/agent/cmd/install.go Outdated Show resolved Hide resolved
internal/pkg/agent/cmd/install.go Show resolved Hide resolved
@kaanyalti kaanyalti requested a review from blakerouse January 22, 2025 16:13
@kaanyalti kaanyalti force-pushed the fix/5595_force_uninstall_correct_installation branch from 22a0dec to a2fe26b Compare January 22, 2025 16:15
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay thanks for the explanation. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--force ignores --develop and uninstalls production agent instead
5 participants