-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/5595 force uninstall correct installation #6559
base: main
Are you sure you want to change the base?
Fix/5595 force uninstall correct installation #6559
Conversation
7066058
to
4991423
Compare
This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a question before approval.
…service display name for messages
22a0dec
to
a2fe26b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay thanks for the explanation. Looks good!
Quality Gate passedIssues Measures |
What does this PR do?
Updates the uninstall command so that when the development agent is installed with
--force
flag and if there is already a development agent, then the command will replace the already existing development agentWhy is it important?
Currently force installing the development agent removes the production agent.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragments
using the changelog toolHow to test this PR locally
--develop
flag--force
flagRelated issues
--force
ignores--develop
and uninstalls production agent instead #5595