Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel: add test for filebeatreceiver delivery guarantees during a collector restart #6228

Merged
merged 16 commits into from
Feb 10, 2025

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Dec 5, 2024

What does this PR do?

This commit adds a integration test that restarts the collector a couple times during the log ingestion and confirms that the data was fully written to elasticsearch.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

…or restart

This commit adds a integration test that restarts the collector a couple
times during a log ingestion and confirms that the data was fully written
to elasticsearch.
@mauri870 mauri870 self-assigned this Dec 5, 2024
@mauri870 mauri870 requested a review from a team as a code owner December 5, 2024 13:27
Copy link
Contributor

mergify bot commented Dec 5, 2024

This pull request does not have a backport label. Could you fix it @mauri870? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Dec 5, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 5, 2024
@mauri870 mauri870 changed the title otel: add test for filebeatreceiver delivery guarantees otel: add test for filebeatreceiver delivery guarantees during a collector restart Dec 5, 2024
@mauri870 mauri870 requested a review from leehinman December 5, 2024 13:43
@mauri870 mauri870 force-pushed the fbreceiver-at-least-once-delivery-test branch from 8481259 to f873c8e Compare December 6, 2024 11:37
@mauri870 mauri870 force-pushed the fbreceiver-at-least-once-delivery-test branch from f873c8e to 6447a5a Compare December 6, 2024 11:48
Copy link

@mauri870 mauri870 requested a review from leehinman December 9, 2024 11:12
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauri870 mauri870 marked this pull request as draft December 10, 2024 11:25
@mauri870 mauri870 marked this pull request as ready for review January 24, 2025 20:34
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank You

@mauri870 mauri870 added the backport-9.0 Automated backport to the 9.0 branch label Feb 6, 2025
@mauri870 mauri870 requested a review from cmacknz February 6, 2025 13:52
@mauri870 mauri870 enabled auto-merge (squash) February 10, 2025 11:11
Copy link

@mauri870 mauri870 merged commit 346a2fe into elastic:main Feb 10, 2025
14 checks passed
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
…ector restart (#6228)

* otel: add test for filebeatreceiver delivery guarantees for a collector restart

This commit adds a integration test that restarts the collector a couple
times during a log ingestion and confirms that the data was fully written
to elasticsearch.

* check that input lines increase after each restart

* use json for docs, use json parser

* add debug exporter, remove fake component from fixture

* fix typo in json input

* add newlines to input file, fixes for recent fingerprint changes

* assert unique log lines

* fix restart counter logic

* update test to restart collector only once

* remove some leftover code

(cherry picked from commit 346a2fe)
mergify bot pushed a commit that referenced this pull request Feb 10, 2025
…ector restart (#6228)

* otel: add test for filebeatreceiver delivery guarantees for a collector restart

This commit adds a integration test that restarts the collector a couple
times during a log ingestion and confirms that the data was fully written
to elasticsearch.

* check that input lines increase after each restart

* use json for docs, use json parser

* add debug exporter, remove fake component from fixture

* fix typo in json input

* add newlines to input file, fixes for recent fingerprint changes

* assert unique log lines

* fix restart counter logic

* update test to restart collector only once

* remove some leftover code

(cherry picked from commit 346a2fe)
mauri870 added a commit that referenced this pull request Feb 11, 2025
…ector restart (#6228) (#6788)

* otel: add test for filebeatreceiver delivery guarantees for a collector restart

This commit adds a integration test that restarts the collector a couple
times during a log ingestion and confirms that the data was fully written
to elasticsearch.

* check that input lines increase after each restart

* use json for docs, use json parser

* add debug exporter, remove fake component from fixture

* fix typo in json input

* add newlines to input file, fixes for recent fingerprint changes

* assert unique log lines

* fix restart counter logic

* update test to restart collector only once

* remove some leftover code

(cherry picked from commit 346a2fe)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch Cleanup skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants