Add entity to the top level namespaces in which it's being used #2556
+2,727
−2,733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add entity to the top level namespace of which it's used in sub-types. For example, we want `user.target.entity` fields to be present. `user.entity` itself is a `user` type, so `entity` must be reused on the user type. This also removes custom generator code which was being used to workaround the fact that this wasn't true before.
|
Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2556/reference/ |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this PR do?
Add entity to the top level namespace of which it's used in sub-types.
For example, we want
user.target.entityfields to be present.user.entityitself is ausertype, soentitymust be reused on the user type.This also removes custom generator code which was being used to workaround the fact that this wasn't true before.
2. Which ECS fields are affected/introduced?
3. Why is this change necessary?
Fixed #2555
4. Have you added/updated documentation?
YES / NO / N/A
5. Have you built ECS and committed any newly generated files?
YES / NO
6. Have you run the ECS validation tests locally?
YES / NO
7. Anything else for the reviewers?
Commit Message