-
Notifications
You must be signed in to change notification settings - Fork 163
Change semantic query example to match query #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as we discussed earlier we should also provide a simpler workflow in follow up work, because the download sample tsv and reindexing steps are quite heavy.
Ideally at least the simple version would be all copy/paste API calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one piece of feedback
"query": "What causes muscle soreness after running?" <2> | ||
"match": { | ||
"content": { | ||
"query": "What causes muscle soreness after running?" <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're removing the first footnote that we're querying on the semantic text field, I don't think this footnote adds a lot of value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ I'd maintain both FWIW
This PR updates an example to use the
match
query instead of thesemantic
query.Connected to: https://github.com/elastic/developer-docs-team/issues/321