Skip to content

Use version variables for Cloud versions #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025

Conversation

colleenmcginnis
Copy link
Contributor

Related to https://github.com/elastic/docs-projects/issues/519

Use version variables from the central configuration instead of relying on docset-level version-related subs so we don't have to update those values in this repo for every release.

@colleenmcginnis colleenmcginnis self-assigned this Jul 24, 2025
Copy link

github-actions bot commented Jul 24, 2025

🔍 Preview links for changed docs

More links …

@colleenmcginnis colleenmcginnis marked this pull request as ready for review July 24, 2025 15:23
@colleenmcginnis colleenmcginnis requested review from a team as code owners July 24, 2025 15:23
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spot check looks good

@@ -177,7 +177,7 @@ spec:
max: 512Gi
```

You can find [a complete example in the ECK GitHub repository](https://github.com/elastic/cloud-on-k8s/blob/{{eck_release_branch}}/config/recipes/autoscaling/elasticsearch.yaml) which will also show you how to fine-tune the [autoscaling deciders](/deploy-manage/autoscaling/autoscaling-deciders.md).
You can find [a complete example in the ECK GitHub repository](https://github.com/elastic/cloud-on-k8s/blob/{{version.eck | M.M}}/config/recipes/autoscaling/elasticsearch.yaml) which will also show you how to fine-tune the [autoscaling deciders](/deploy-manage/autoscaling/autoscaling-deciders.md).
Copy link
Contributor

@kilfoyle kilfoyle Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colleenmcginnis Just checking: Is it expected that this link currently 404s with {{version.eck | M.M}} resolving to 3.2?
https://github.com/elastic/cloud-on-k8s/blob/3.2/config/recipes/autoscaling/elasticsearch.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 3.2 the latest ECK version? If not, we should update https://github.com/elastic/docs-builder/blob/main/config/versions.yml#L19.

Copy link
Contributor

@kilfoyle kilfoyle Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the release schedule, ECK 3.1 is due for release next week; 3.2 is planned for a few months later.
The ECK docs are (correctly) showing 3.0.

Here's a PR that I think should be merged when ECK 3.1 goes live next week:
elastic/docs-builder#1608

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 updated the versions.yml config in elastic/docs-builder#1611 to use 3.0 as current, which is where the version.eck variable comes from so the link is now working. 🎉

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@colleenmcginnis colleenmcginnis merged commit bb176b3 into main Jul 25, 2025
8 checks passed
@colleenmcginnis colleenmcginnis deleted the use-version-variables-cloud branch July 25, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants