-
Notifications
You must be signed in to change notification settings - Fork 103
ECH: Move nodes off allocator doc updated #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@kunisen , about the comment you have shared:
The headings are in "Q&A" format style already, but that's something I wasn't sure if it was the right approach, and I wanted to double check that with other docs folks. I agree if the headings are kept in this Q&A format, then a "Frequently Asked Questions" heading would make all sense, but maybe we rewrite the headers to be in a different format. cc: @shainaraskas , what would you say? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few small comments, but other than that LGTM!
this isn't really in our style (reasoning) and could be reworked a couple of them should be removed (e.g. the support CTA), or integrated into the doc ("Could such a system maintenance be avoided or skipped?" should just be introductory information about why this happens and its inevitability) some could be pulled into an "Availability during system maintenance" section and perhaps "Data loss risk for non-HA deployments" some of them could be reworded ("How can I be notified when a node is changed?" > "Notifications for moved or changed nodes" [more task-based]). I do think that if we want to keep these together, they do need a heading of their own so they're not nested below "Possible causes and impact" |
Co-authored-by: Stef Nestor <[email protected]>
@shainaraskas : I'll do some rework on this to avoid the FAQ style while keeping all the key points we want to communicate to the users. Thanks a lot for your feedback! |
Thanks for being patient and all the help! 🙏 [1]I made a bunch of updates based on internal ticket comments - https://github.com/elastic/support-tech-lead/issues/1576#issuecomment-2948156720. Here's the preview: [2]@eedugon I totally get what you and @shainaraskas said above #1619 (comment). Please feel free to make any updates from docs perspective based on your writing standard. I still added Again, please feel free to make your change even including the removal of that one. [3]Also, I believe it's technically clear now so no longer need to discuss anything further internally. But if still anything is technically unclear or regarding the expectation, let's still discuss it internally ha :) |
@kunisen , very good suggestion, next time feel free to add them directly in the code (as I've applied the changes, thanks a lot! |
Thanks @eedugon indeed I will use suggest next time. 🙏 @shainaraskas could you kindly help us double check if we are good to go please? Then I think we should be good to go :) |
Co-authored-by: shainaraskas <[email protected]>
🔍 Preview links for changed docs: 🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes. |
Thank you so much for all the detailed suggestions. Very clear and helpful! Based on your suggestion, I almost rewrote the whole page in a more logical way. That said, may I trouble you to review it again and see if we could publish this one in this week please? Motivation of my proactive work on this is because we yet got another ask by users and our team members, and I want to make it publish as soon as we could. Thanks for your patience and understanding again! cc @eedugon |
…tic/docs-content into ech_node_moves_troubleshoot
Also @shainaraskas could you help solve this please? ![]() https://github.com/elastic/docs-content/actions/runs/15755256766
I have no idea about how to refer to a kibana doc in cloud docs... |
As described in #1527, this PR is promoting a knowledge article into our existing doc, per @kunisen and support team request.
Preview:
Changes:
Links to existing KB:
Closes #1527