Skip to content

Add documentation for failure stores. #1368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Jun 26, 2025
Merged

Add documentation for failure stores. #1368

merged 37 commits into from
Jun 26, 2025

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented May 5, 2025

TBD on recipes. Most links are not complete and need updating from "???".
Copy link
Member

@PeteGillinElastic PeteGillinElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far! I have one drive-by comment.

@bvader
Copy link

bvader commented May 19, 2025

Hi @jbaiera I noticed a small issue

https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/1368/manage-data/data-store/data-streams/failure-store#use-failure-store

This example

POST my-datastream/_bulk
{"create":{}}
{"@timestamp": "2025-05-01T00:00:00Z", "id": 1234}
{"create":{}}
{"@timestamp": "2025-05-01T00:00:00Z", "id": "invalid_text"}

Should be add the -new (<namespace>) otherwise it does not match the template at the top of the page and thus does not match and thus does not work :)

POST my-datastream-new/_bulk
{"create":{}}
{"@timestamp": "2025-05-01T00:00:00Z", "id": 1234}
{"create":{}}
{"@timestamp": "2025-05-01T00:00:00Z", "id": "invalid_text"}

@slobodanadamovic
Copy link

Is there anywhere else that we should expand with more failure store info for security beyond that reference?

No, that's the only place we should document them.

I left some comments. I think we should try to point out that the new privileges are only granting access to failure store when accessed using ::failures selector, but I'm blanking on a concrete suggestion right now. Will try to think overnight.

@dakrone dakrone self-requested a review June 16, 2025 16:59
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some comments, but nothing major. This is a monumental amount of work and I think it's great, thanks Jimmy.

@sabarasaba
Copy link
Member

@dakrone Any chance we might get this before FF for 8.19? We've made some work in the kibana UI and would be great if we can add a link to the docs

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @jbaiera! just adding a couple of comments to address the metadata of these pages / improve wayfinding between the pages. also approving to make sure that you're unblocked. let me know if you need a hand with anything.

Copy link

github-actions bot commented Jun 20, 2025

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix the failing test

rStelmach added a commit to elastic/kibana that referenced this pull request Jun 24, 2025
…ream (#221644)

Added a tooltip and a link with documentation for Failed docs column
when dataset does not have failure store enabled.



https://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e




For now it awaits for the documentation PR to be merged :
elastic/docs-content#1368

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Yngrid Coello <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 24, 2025
…ream (elastic#221644)

Added a tooltip and a link with documentation for Failed docs column
when dataset does not have failure store enabled.

https://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e

For now it awaits for the documentation PR to be merged :
elastic/docs-content#1368

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Yngrid Coello <[email protected]>
(cherry picked from commit 36cbbb9)
kibanamachine added a commit to elastic/kibana that referenced this pull request Jun 24, 2025
…data stream (#221644) (#225007)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Dataset Quality] Indicate if failure store isn't enabled for data
stream (#221644)](#221644)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Robert
Stelmach","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-24T07:49:36Z","message":"[Dataset
Quality] Indicate if failure store isn't enabled for data stream
(#221644)\n\nAdded a tooltip and a link with documentation for Failed
docs column\nwhen dataset does not have failure store
enabled.\n\n\n\nhttps://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e\n\n\n\n\nFor
now it awaits for the documentation PR to be merged
:\nhttps://github.com/elastic/docs-content/pull/1368\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>\nCo-authored-by:
Yngrid Coello
<[email protected]>","sha":"36cbbb9bf8f141a54bb6c455e4479e93990d9626","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","Feature:Dataset
Health","backport:version","v9.1.0","v8.19.0"],"title":"[Dataset
Quality] Indicate if failure store isn't enabled for data
stream","number":221644,"url":"https://github.com/elastic/kibana/pull/221644","mergeCommit":{"message":"[Dataset
Quality] Indicate if failure store isn't enabled for data stream
(#221644)\n\nAdded a tooltip and a link with documentation for Failed
docs column\nwhen dataset does not have failure store
enabled.\n\n\n\nhttps://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e\n\n\n\n\nFor
now it awaits for the documentation PR to be merged
:\nhttps://github.com/elastic/docs-content/pull/1368\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>\nCo-authored-by:
Yngrid Coello
<[email protected]>","sha":"36cbbb9bf8f141a54bb6c455e4479e93990d9626"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221644","number":221644,"mergeCommit":{"message":"[Dataset
Quality] Indicate if failure store isn't enabled for data stream
(#221644)\n\nAdded a tooltip and a link with documentation for Failed
docs column\nwhen dataset does not have failure store
enabled.\n\n\n\nhttps://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e\n\n\n\n\nFor
now it awaits for the documentation PR to be merged
:\nhttps://github.com/elastic/docs-content/pull/1368\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>\nCo-authored-by:
Yngrid Coello
<[email protected]>","sha":"36cbbb9bf8f141a54bb6c455e4479e93990d9626"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Stelmach <[email protected]>
Co-authored-by: Yngrid Coello <[email protected]>
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
…ream (elastic#221644)

Added a tooltip and a link with documentation for Failed docs column
when dataset does not have failure store enabled.



https://github.com/user-attachments/assets/be65db9a-15c8-4087-b175-752b2fabab6e




For now it awaits for the documentation PR to be merged :
elastic/docs-content#1368

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Yngrid Coello <[email protected]>
@jbaiera jbaiera enabled auto-merge (squash) June 26, 2025 20:48
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing links to anchors to get the PR green

@jbaiera jbaiera merged commit 2dfdbe0 into main Jun 26, 2025
7 of 8 checks passed
@jbaiera jbaiera deleted the failure-store-docs branch June 26, 2025 21:21
@shainaraskas shainaraskas mentioned this pull request Jun 26, 2025
shainaraskas added a commit that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants