Skip to content

Update applicability lifecycles to match versioning RFC #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2025

Conversation

Mpdreamz
Copy link
Member

No description provided.

@Mpdreamz Mpdreamz added the fix label Jun 18, 2025
@Mpdreamz Mpdreamz requested a review from a team as a code owner June 18, 2025 17:59
@Mpdreamz Mpdreamz self-assigned this Jun 18, 2025
@Mpdreamz Mpdreamz requested a review from a team as a code owner June 18, 2025 19:38
@@ -200,7 +200,7 @@ jobs:
with:
prefix: ${{ env.PATH_PREFIX }}
strict: ${{ fromJSON(inputs.strict != '' && inputs.strict || 'true') }}
metadata-only: ${{ fromJSON(inputs.metadata-only != '' && inputs.metadata-only || 'true') }}
metadata-only: ${{ fromJSON(inputs.metadata-only != '' && inputs.metadata-only || 'false') }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the default value on the inputs, was confusing to read true even though this always defaults to false.

Copy link
Contributor

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! (At least the bits that I can understand :D)

We can clean up the rest of the examples in the applies_to docs page in that other PR #1325 that puts more guidance into it too

@Mpdreamz Mpdreamz merged commit 50db168 into main Jun 20, 2025
15 checks passed
@Mpdreamz Mpdreamz deleted the fix/update-applicability-lifecycles branch June 20, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants