[Bug] [DAC] Kibana Export Rules Rule Name Filter Exports All Rules #4917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Resolves #4916
Summary - What I changed
Added a simple check to see if the requested Kibana filter returns any rule_ids associated with the provided name for
kibana export-rules
via the-rn
flag.How To Test
Run the export rules command with a filter for a rule name that does not exist. This should no longer export any rules and print a message identifying that no rules were exported.
E.g.
python -m detection_rules kibana --space test_local export-rules -rn "My Test Rule" -d dac_test/rules/ -sv
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist