Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm] Updated pod labels to include all standard k8s labels and updated hel… #8278

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Helm] Updated pod labels to include all standard k8s labels and updated hel… #8278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/eck-operator/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
labels:
{{- include "eck-operator.selectorLabels" . | nindent 8 }}
{{- include "eck-operator.labels" . | nindent 8 }}
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down
12 changes: 12 additions & 0 deletions deploy/eck-operator/templates/tests/statefulset_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ tests:
key1: value1
statefulsetLabels:
key2: value2
podLabels:
key3: value3
asserts:
- template: statefulset.yaml
equal:
Expand All @@ -78,6 +80,16 @@ tests:
app.kubernetes.io/version: 2.16.0-SNAPSHOT
helm.sh/chart: eck-operator-2.16.0-SNAPSHOT
key2: value2
- template: statefulset.yaml
equal:
path: spec.template.metadata.labels
value:
app.kubernetes.io/instance: RELEASE-NAME
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: elastic-operator
app.kubernetes.io/version: 2.16.0-SNAPSHOT
helm.sh/chart: eck-operator-2.16.0-SNAPSHOT
key3: value3
- it: should use the specified webhook secret name
set:
webhook:
Expand Down