Replace dgraph-io/badger cache storage with etcd-io/bbolt #42571
+356
−596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
stefans-elastic
added
the
Team:Obs-InfraObs
botelastic
bot
removed
the
needs_team
stefans-elastic
added
needs_team
botelastic
bot
removed
the
needs_team
|
This pull request doesn't have a |
stefans-elastic
changed the title
mauri870
reviewed
Feb 4, 2025
| ExpireAt int64 `json:"expireAt"` | ||
|
|
||
| // Ttl - Time To Live used for value. If 0 then the value doesn't expire | ||
| Ttl time.Duration `json:"ttl"` |
There was a problem hiding this comment.
mauri870
reviewed
Feb 4, 2025
Comment on lines
+104
to
+106
| defer func() { | ||
| _ = tx.Rollback() | ||
| }() |
There was a problem hiding this comment.
Can't Update be used here to wrap the get logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Replacing dgraph-io/badger persistent storage for key-value cache with etcd-io/bbolt. Originally it was meant to just get rid of
go.opencensus.iodependency which is introduced by badger (please see parent issue for more details). After it got evident that this won't erasego.opencensus.iodependency it was decided that this work still should be done since etcd-io/bbolt is already used elsewhere in the project and it isn't a good thing to have multiple storages for cache (again, please see parent issue for more details (in comments)).Implementation should be fairly straight-forward but I would like to clarify one thing - since bolt doesn't support value expiration the expiration time (and TTL) are stored as metadata of the value. Upon value retrieval it is checked for expiration and if it is expired then nil is returned and value gets deleted from bolt DB.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs