Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append a function that automatically adds other incorrect options. #4

Merged
merged 2 commits into from
Mar 31, 2018

Conversation

wotchin
Copy link

@wotchin wotchin commented Mar 9, 2018

This function was implemented by NLP(Natural Language Processing) module.
This can greatly reduce labor costs and enjoy the benefits of artificial intelligence(AI).

@mtancoigne mtancoigne self-requested a review March 11, 2018 09:34
@mtancoigne
Copy link
Member

Hi !
Thanks for your PR, i'll test it as soon as possible :)

@wotchin
Copy link
Author

wotchin commented Mar 12, 2018

Thank you.
And by the way,there is a few syntax errors from json file in the folder named 'todo',such as losing '[' or ']' ,and appending extra ',' in the end.
So before your test,you could fix the files or the program would product parsing errors.
:)

Copy link
Member

@mtancoigne mtancoigne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module is interesting, but we should support more languages, so it may be a good idea to put it outside of the 'en' folder.

I think we can have an "answer generator" or something like that.

Additionally, it outputs the files in the same directory, but I think we should have something like:

<language>
   todo/      <--- List of new questions
   need_review/ <--- Questions with answers, needing review and sources
   ready/    
   <files>  <--- approved questions

I'll update master with this structure, so you can adapt your PR (and i'll fix the issues in JSON files)

@wotchin
Copy link
Author

wotchin commented Mar 30, 2018

Ok,see.I will try.

@wotchin
Copy link
Author

wotchin commented Mar 30, 2018

Hello,I have done.

@mtancoigne
Copy link
Member

I'm looking at it today. By the way, i'm searching for people interested into doing something useful with those data: a website to submit and validate the questions and answers. Are you interested to jump in ? There is still no language or tools defined, so the discussion is open...

@mtancoigne mtancoigne changed the base branch from master to feature/nlp March 31, 2018 13:37
@mtancoigne
Copy link
Member

I tested your script and I got some issues with it, so i'll merge the PR in a feature/nlp branch so we can work on it and adapt it before merging in the master branch.

@mtancoigne mtancoigne merged commit d305c4d into el-cms:feature/nlp Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants