refactor: move IDE selection to inline dropdown in Folder view (#1254)#1261
Open
eureka928 wants to merge 3 commits intoeigent-ai:mainfrom
Open
refactor: move IDE selection to inline dropdown in Folder view (#1254)#1261eureka928 wants to merge 3 commits intoeigent-ai:mainfrom
eureka928 wants to merge 3 commits intoeigent-ai:mainfrom
Conversation
Move IDE selection to the point of action via a dropdown menu on the terminal icon button, offering "Open in VS Code", "Open in Cursor", and "Open in File Manager" options. Remembers last choice via authStore.
The IDE selection is now handled inline in the Folder view dropdown, making this settings section redundant.
Add open-in-vscode, open-in-cursor, open-in-file-manager keys to chat.json across all 11 locales. Remove obsolete preferred-ide, preferred-ide-description, and system-file-manager keys from setting.json.
Collaborator
|
Can you add a short video or snapshot for your PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1254 — The "Open in IDE" feature (PR #1159) currently splits the action across two disconnected places: a "Preferred IDE" dropdown in Settings → General and a terminal icon button in the Folder view header. This is hard to discover and adds unnecessary friction.
This PR moves IDE selection to the point of action by replacing the single icon button with an inline DropdownMenu that offers three options directly: "Open in VS Code", "Open in Cursor", and "Open in File Manager". The last choice is remembered via
authStore.setPreferredIDE(). The now-redundant Settings section is removed.Key Changes:
src/components/Folder/index.tsx:<Button>with a<DropdownMenu>using the same terminal icon as triggerhandleOpenInIDE(ide)functionauthStore.setPreferredIDE(ide)src/pages/Setting/General.tsx:src/i18n/locales/*/chat.json(11 locales):open-in-vscode,open-in-cursor,open-in-file-managerkeys with translationssrc/i18n/locales/*/setting.json(11 locales):preferred-ide,preferred-ide-description,system-file-managerkeysNo changes needed:
src/store/authStore.ts—preferredIDE+ persistence kept (still used to remember last choice)electron/main/index.ts— IPC handlers unchangedelectron/preload/index.ts— Preload bridge unchangedWhat is the purpose of this pull request?